From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8251 invoked by alias); 16 Feb 2017 16:46:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40560 Received: (qmail 8755 invoked from network); 16 Feb 2017 16:46:47 -0000 X-Qmail-Scanner-Diagnostics: from mailout3.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.13):SA:0(-5.0/5.0):. Processed in 1.162838 secs); 16 Feb 2017 16:46:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f4-f79716d000006f65-41-58a5d51456b0 Date: Thu, 16 Feb 2017 16:36:32 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] db/gdbm rewrite Message-id: <20170216163632.6d26685e@pwslap01u.europe.root.pri> In-reply-to: <1487262324.1911841.883231656.222E231A@webmail.messagingengine.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djPc7oiV5dGGOz/y29xsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4Mub8aWQv+MNZ8epFcQPjd/YuRk4OCQETied3+xghbDGJC/fW s3UxcnEICSxllJjZtxwsISTQyyTx448cTMOVZcvYIYqWMUqs+roXqmMak8T1jk5mCOcMo8Sk C+ugys4ySrS/XwuU4eBgEVCV2NpZCzKKTcBQYuqm2WArRATEJc6uPc8CYgsLqEg0fethArF5 BewlPv88xwZicwoESBz83ANm8wvoS1z9+4kJ4iR7iZlXzjBC1AtK/Jh8D2wOs4COxLZtj9kh bHmJzWvegh0nIdDMLtH09SMryD0SArISmw4wQ8xxkVjefBFqprDEq+NboGEkI3F5cjcLhN3P KPGk2xdizgxGidNndrBBJKwl+m5fZIRYxicxadt0Zoj5vBIdbUIQJR4ST+/dgZrvKLGnYTr7 BEbFWUjOnoXk7FlIzl7AyLyKUSS1tDg3PbXYRK84Mbe4NC9dLzk/dxMjMAmc/nf8yw7Gxces DjEKcDAq8fBmbF8aIcSaWFZcmXuIUYKDWUmEN2MtUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv ngVXwoUE0hNLUrNTUwtSi2CyTBycUg2MG6etv8f9+n+KIsOpWQaJGp/t+suvv0zmf2rPs3BX XK7dpvnuzx9JTxD79sSJe/FMa5kfX71624Q3Gp2acWbZnrq4Aw5rNp3g52kv2j7/6lcO5d/K T70Zn9fNjPErXpitlpxznaXyS75V49S289s0ev+WvJskEG3T5Ctz2W+V2f+udaw3s2f/VGIp zkg01GIuKk4EADg39jH+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t/xK7riV5dGGOx/omBxsPkhkwOjx6qD H5gCGKPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg 4BzgHqykb5fgljHnTyN7wR/OilcvihsYv7N3MXJySAiYSFxZtgzKFpO4cG89WxcjF4eQwBJG iZmLDrNCODOYJH68/sYI4ZxjlLiz8QEThHOWUWJew06WLkYODhYBVYmtnbUgo9gEDCWmbprN CGKLCIhLnF17ngXEFhZQkWj61sMEYvMK2Et8/nmODcTmFAiQOPi5B2r1c1aJ3p4NzCAJfgF9 iat/PzFB3GcvMfPKGUaIZkGJH5PvgQ1lFtCS2LytiRXClpfYvOYtWK+QgLrEjbu72ScwCs9C 0jILScssJC0LGJlXMYqklhbnpucWG+kVJ+YWl+al6yXn525iBEbRtmM/t+xg7HoXfIhRgINR iYc3Y/vSCCHWxLLiytxDjBIczEoivBlrgUK8KYmVValF+fFFpTmpxYcYTYEBM5FZSjQ5Hxjh eSXxhiaG5paGRsYWFuZGRkrivFM/XAkXEkhPLEnNTk0tSC2C6WPi4JRqYDzKffsJi8mpLoWt ylELgw5385mtfBtT1fBdOj3Mpjihwb98f92mHVeqCsJc2Dz5uY6qL5n4+PzZlK8v42Wi+nf4 9V4zsV347qnrv9AzJ7YVcbak/1K4sXXl39qWyW7fgvaavju49D3rTsm0uv7d961/RKxU1X7G /uTJ5qj8NcIZi5h+Z2RYzlRiKc5INNRiLipOBAAxpqKruAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170216163635eucas1p1e20d053174385530ab706280619fddd4 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170215102727epcas1p4e08c26a6f0e39459b496db85e37df63f X-RootMTR: 20170215102727epcas1p4e08c26a6f0e39459b496db85e37df63f References: <1487074831.317363.880495280.04595B08@webmail.messagingengine.com> <1487154163.615323.881647656.040AB25F@webmail.messagingengine.com> <20170216101658.46555c47@pwslap01u.europe.root.pri> <1487245575.1843244.882932424.59844A89@webmail.messagingengine.com> <20170216125215.1b744bf6@pwslap01u.europe.root.pri> <1487255103.1880827.883083384.73295E85@webmail.messagingengine.com> <1487255450.1882152.883095336.5DDBE902@webmail.messagingengine.com> <20170216151152.0f5a07ef@pwslap01u.europe.root.pri> <1487261017.1907093.883202288.270632CF@webmail.messagingengine.com> <1487262324.1911841.883231656.222E231A@webmail.messagingengine.com> On Thu, 16 Feb 2017 08:25:24 -0800 Sebastian Gniazdowski wrote: > On Thu, Feb 16, 2017, at 08:03 AM, Sebastian Gniazdowski wrote: > > On Thu, Feb 16, 2017, at 07:11 AM, Peter Stephenson wrote: > > > % zmodload zsh/db/gdbm > > > % ztie -d db/gdbm -f db.gdbm dbase > > > % dbase[testkey]=somewhat > > > ==25034== Invalid write of size 1 > > > ==25034== at 0x80E0B78: metafy (utils.c:4652) > > > > I've used HEAP_ALLOC instead of HEAP_DUP in argument for metafy. Fixing > > this resolves valgrind report. Important catch.. Hopefully it will > > resolve enable-zsh-mem problem (I cannot reproduce that). Sending as > > complete patch plus db_gdbm.c file. > > Yeah this will fix the problem. I did: > > pm->u.str = metafy(content.dptr, content.dsize, META_ALLOC); > > There were no meta characters so metafy() didn't allocate memory, > returned internal GDBM pointer. META_DUP always allocates. Thanks! Yes, test now runs in the case where it originally failed with zsh allocation. I think that's probably all the sanity checking this is going to get in these parts. Unless someone screams in appropriately technical language (or, even better, wants to do some checking of their own) I'll commit it. pws