zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
Date: Tue, 28 Feb 2017 07:45:49 +0000	[thread overview]
Message-ID: <20170228074549.GA8753@fujitsu.shahaf.local2> (raw)
In-Reply-To: <170226114216.ZM4201@torch.brasslantern.com>

Bart Schaefer wrote on Sun, Feb 26, 2017 at 11:42:16 -0800:
> On Feb 26,  6:16am, Daniel Shahaf wrote:
> } Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
> }
> } Bart Schaefer wrote on Sat, Feb 25, 2017 at 16:04:55 -0800:
> } > This is just the first one that dies:
> } 
> } I could swear 'make check' had passed before I pushed this, but I can
> } reproduce this.  No time to debug, so reverted.  Sorry for the breakage.
> 
> workers/40508 always seemed questionable to me.
> 
> I suspect this is what comes of some attempt to optimize assignments.
> There may be cases where the recopy operation in these set*() functions
> is redundant, but I don't feel like tracking that down just now; it is
> definitely necessary for $options, so ...

Thanks for fixing this.

For future reference, James (who reported the original bug offlist) has
since reported another symptom:

% autoload -Uz compinit; compinit; setopt listambiguous; options+=()
% <accept-line>
% a<TAB>
zsh: Segmentation fault  Src/zsh -f

The latest patch fixes this one, too.


  parent reply	other threads:[~2017-02-28  7:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26  0:04 Bart Schaefer
2017-02-26  6:16 ` Daniel Shahaf
2017-02-26 19:42   ` Bart Schaefer
2017-02-27  9:31     ` Sebastian Gniazdowski
2017-02-28  7:45     ` Daniel Shahaf [this message]
2017-02-28 16:38       ` Bart Schaefer
2017-02-28 17:03         ` Daniel Shahaf
2017-02-28 19:04           ` Bart Schaefer
2017-02-28 21:51             ` Daniel Shahaf
2017-03-01 15:55               ` Bart Schaefer
2017-02-27  9:41 Sebastian Gniazdowski
2017-02-27 16:42 ` Bart Schaefer
2017-02-27 18:48   ` Sebastian Gniazdowski
2017-02-27 20:08     ` Daniel Shahaf
2017-02-27 20:38       ` Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228074549.GA8753@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).