From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24203 invoked by alias); 3 Mar 2017 10:11:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40712 Received: (qmail 23719 invoked from network); 3 Mar 2017 10:11:34 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. Processed in 0.868747 secs); 03 Mar 2017 10:11:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UwN0lFp91dVjUVN N0DiIjlXh49k=; b=rAMY52LxVhMgeLIWNuN3WJEFlALgLMDhY1q5/2CKBJ5HaIE 1kilEi/+CjrrD4Uu6ZORDFxFZieD8rbFTMkmUSpSkcaHAXrTuzr76k/8h2ttf4QT G/NyV/PpDXYSNwGCabVNynkvA2lXN+sB4B6ajnOwbuHqgru3sp/T3BtK2Zfo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=UwN0lFp91dVjUV NN0DiIjlXh49k=; b=T/ZNySF2IYh9ltdmdFeAfYMbyx/rVTRJbN6cEsoFLNB++S n5obaf7DnSMEB7IItSTJMobafr6OjaF7+JKA5INlX1w1fDn/HDb1e0eJg0/HANN3 56ZvrFkUDd1CehDJDh3X8ESYfxfaah6QtG9nhbgIy288eu3AeOyF8MPfSwzvw= X-ME-Sender: X-Sasl-enc: jTThkeyuIMDmU0YBGjHczcG3t+4ZoklDMRfVFKE8ytLR 1488535195 Date: Fri, 3 Mar 2017 09:55:15 +0000 From: Daniel Shahaf To: Peter Stephenson Cc: zsh-workers@zsh.org Subject: Re: Skipping gdbm test Message-ID: <20170303095515.GA3953@fujitsu.shahaf.local2> References: <20170302150541.7f2c89f7@pwslap01u.europe.root.pri> <1488471464.113806.898254512.0339C552@webmail.messagingengine.com> <20170303091902.6fb98763@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170303091902.6fb98763@pwslap01u.europe.root.pri> User-Agent: Mutt/1.5.23 (2014-03-12) Peter Stephenson wrote on Fri, Mar 03, 2017 at 09:19:02 +0000: > On Thu, 02 Mar 2017 08:17:44 -0800 > Sebastian Gniazdowski wrote: > > Maybe the skip could be done more quiet? I've followed V10private.tst, > > but that module is easily built. Checked that in %prep path to gdbm > > module file is: Modules/zsh/db/gdbm.so > > I don't think it's a problem. Skipping is common within tests, too, > depending on system features. It's just when something changes that > people notice. I think the proposal was to removal lines 2,3 but keep lines 1,4: >>>> 1 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting. >>>> 2 (eval):3: failed to load module `zsh/db/gdbm': >>>> 3 /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared object file: No such file or directory >>>> 4 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load zsh/db/gdbm module for testing) Personally I think it'd be good to hide that particular error message; line 4 tells the user what he needs to know. CHeers, Daniel