From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6068 invoked by alias); 3 Mar 2017 10:15:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40713 Received: (qmail 26095 invoked from network); 3 Mar 2017 10:15:00 -0000 X-Qmail-Scanner-Diagnostics: from mailout3.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.13):SA:0(-5.0/5.0):. Processed in 0.750878 secs); 03 Mar 2017 10:15:00 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7f2-f790f6d000002555-04-58b9421d60c2 Date: Fri, 03 Mar 2017 10:14:50 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: Skipping gdbm test Message-id: <20170303101450.529af846@pwslap01u.europe.root.pri> In-reply-to: <20170303095515.GA3953@fujitsu.shahaf.local2> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7pyTjsjDC5vZrI42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGc++b2MpOMdZ8ehtagPjffYuRk4OCQETiRNLP7JC2GISF+6t ZwOxhQSWMkp0dwPFuYDsXiaJnjnb2WAaLs06xg5RtIxRYtEsawh7GpPEqr3pEA2nGSVub3rP BOGcYZR4dP0WC0gVi4CqxO/L3cwgNpuAocTUTbMZQWwRAXGJs2vPA9VwcAgLyEucfacCYvIK 2Evc+yMKUsEpYCXR9rAfbC+/gL7E1b+fmCDusZeYeeUM2BReAUGJH5PvgW1iFtCR2LbtMTuE LS+xec1bZpBzJAT+s0m0zzkOtkpCQFZi0wFmiDkuEpeePoKyhSVeHd8CDSAZicuTu1kg7H5G iSfdvhBzZjBKnD6zAxoo1hJ9ty8yQizjk5i0bTozxHxeiY42IYgSD4mXb1ZBzXeU+L7mNfsE RsVZSM6eheTsWUjOXsDIvIpRJLW0ODc9tdhYrzgxt7g0L10vOT93EyMw/k//O/5pB+PXE1aH GAU4GJV4eC/Y7IgQYk0sK67MPcQowcGsJMKbthcoxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfP givhQgLpiSWp2ampBalFMFkmDk6pBkZ+E6sfrw8fXLPaI37NTT/rO7Zqjb/u+x/9GLqiskf6 8mWeUsVFjybLFFpNWRTnlGV284zKosk7ph3U0z695ONMbpbEgrvP7+Y9FVFqX+666KLW6uWZ 1Q5FDFPZFbczlhxePaVgsYyLv/jdh4u1blkGncx54uO6e5Ku+MNVz77elA2eMHNfikOVEktx RqKhFnNRcSIA42lO3/sCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xa7pqTjsjDD6tV7Y42PyQyYHRY9XB D0wBjFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpw cA5wD1bSt0twy3j2fRtLwTnOikdvUxsY77N3MXJySAiYSFyadQzKFpO4cG89G4gtJLCEUaK5 WRHCnsEkseCffBcjF5B9mlHi1KIZ7BDOGUaJ7oufmUGqWARUJX5f7gaz2QQMJaZums0IYosI iEucXXuepYuRg0NYQF7i7DsVEJNXwF7i3h9RkApOASuJtof9UCPbmSUmTLjKCpLgF9CXuPr3 ExPEcfYSM6+cARvJKyAo8WPyPRYQm1lAS2LztiZWCFteYvOat8wQR6tL3Li7m30Co/AsJC2z kLTMQtKygJF5FaNIamlxbnpusZFecWJucWleul5yfu4mRmD8bDv2c8sOxq53wYcYBTgYlXh4 Nex3RAixJpYVV+YeYpTgYFYS4U3bCxTiTUmsrEotyo8vKs1JLT7EaAoMl4nMUqLJ+cDYziuJ NzQxNLc0NDK2sDA3MlIS55364Uq4kEB6YklqdmpqQWoRTB8TB6dUA+NGPYfp3/5oP3K7v+b1 StG5cu+ulEyctHP2Y87siQeP/rYViVN/0Del49ZrjzuyCR/V82/OyOSRWj3NV3NbfZqqIveu Xc+unrl9Q6D56nPt+P0RzwTrtCzyfCryw6y9mp+slt0ft9F4qcC6RH63SPldOWtudL9ftfTi YpEvFcdOJm+w0J+1u3KNEktxRqKhFnNRcSIAj/ni77UCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170303101453eucas1p14247e426371e71d6eb9303612d0014ac X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170302145932epcas5p18f7477866f38d8bbc75a640afffa04cd X-RootMTR: 20170302145932epcas5p18f7477866f38d8bbc75a640afffa04cd References: <20170302150541.7f2c89f7@pwslap01u.europe.root.pri> <1488471464.113806.898254512.0339C552@webmail.messagingengine.com> <20170303091902.6fb98763@pwslap01u.europe.root.pri> <20170303095515.GA3953@fujitsu.shahaf.local2> On Fri, 3 Mar 2017 09:55:15 +0000 Daniel Shahaf wrote: > I think the proposal was to removal lines 2,3 but keep lines 1,4: > > >>>> 1 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: starting. > >>>> 2 (eval):3: failed to load module `zsh/db/gdbm': > >>>> 3 /opt/build/zsh-2017-03-01/Test/Modules/zsh/db/gdbm.so: cannot open shared object file: No such file or directory > >>>> 4 /opt/src/zsh-2017-03-01/Test/V11db_gdbm.ztst: skipped (can't load zsh/db/gdbm module for testing) > > Personally I think it'd be good to hide that particular > error message; line 4 tells the user what he needs to know. Oh, yes, we don't need the shell error message, since it's not a hard test error. The skipped message from the test system is enough. This is how various of the other module tests work. pws diff --git a/Test/V11db_gdbm.ztst b/Test/V11db_gdbm.ztst index 486ad48..1d80f28 100644 --- a/Test/V11db_gdbm.ztst +++ b/Test/V11db_gdbm.ztst @@ -4,7 +4,7 @@ modname="zsh/db/gdbm" dbfile=db.gdbm - if ! zmodload $modname ; then + if ! zmodload $modname 2>/dev/null; then ZTST_unimplemented="can't load $modname module for testing" fi rm -f db.gdbm