From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16911 invoked by alias); 10 Mar 2017 09:56:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40819 Received: (qmail 7790 invoked from network); 10 Mar 2017 09:56:53 -0000 X-Qmail-Scanner-Diagnostics: from mailout3.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.13):SA:0(-5.0/5.0):. Processed in 1.376577 secs); 10 Mar 2017 09:56:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts) X-AuditID: cbfec7ef-f79d26d00000420c-8a-58c2760255e1 Date: Fri, 10 Mar 2017 09:46:37 +0000 From: Peter Stephenson To: Zsh hackers list Subject: Re: IS_DASH() warning Message-id: <20170310094637.240cf95b@pwslap01u.europe.root.pri> In-reply-to: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djPc7pMZYciDC5NM7U42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGRsePmYv+MRV8WD6d5YGxg6OLkZODgkBE4kFp44zQthiEhfu rWfrYuTiEBJYxihxatVvKKeXSaJ7/XcWmI6DjxYwwVVt+3YOqmoak8TSkx0sEM4ZRonG/0eY IZyzjBJdayYygfSzCKhKTPr0C2wWm4ChxNRNs8G2iwhoSew4eRKsRlhATuLmzS9gcV4Be4n7 r/+wgdicAsESE65OZgex+QX0Ja7+/cQEcZO9xMwrZ6DqBSV+TL4HNp9ZQEdi27bH7BC2vMTm NW/BDpIQ+M8mser9cyCHA8iRldh0gBlijovEyu6L7BC2sMSr41ugbBmJy5O7of7vZ5R40u0L MWcGo8TpMzvYIBLWEn23LzJCLOOTmLRtOtR8XomONiGIEg+JrctuQ0PbUWLXpZvMExgVZyE5 exaSs2chOXsBI/MqRpHU0uLc9NRiQ73ixNzi0rx0veT83E2MwFRw+t/x9zsYnzaHHGIU4GBU 4uGdkX0wQog1say4MvcQowQHs5IIb0bBoQgh3pTEyqrUovz4otKc1OJDjNIcLErivHsXXAkX EkhPLEnNTk0tSC2CyTJxcEo1MNos8X5byyT//nT24o9Lwn4vyXtYqC3y0WTSAb2kN+Lf7aND Y1xdpn7/3PUmhnHb+kmqXcfXTZh3ZD9/PFeY6w9eu/XCz0w+N3u+DF9tumx6h3fXmoY99ilL /z2c1vNI8rqjcPm0U+/fHM+8MeMry+kpRxXfd00r2Z8hcPfZVYPd/c6/zgg5a29XYinOSDTU Yi4qTgQAWBkcXQEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t/xq7pcZYciDCZ0m1scbH7I5MDoserg B6YAxig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04 OAe4Byvp2yW4ZWx4+Ji94BNXxYPp31kaGDs4uhg5OSQETCQOPlrABGGLSVy4t56ti5GLQ0hg CaPE2U/nWEESQgIzmCTmnBCFSJxjlJi36yM7hHOWUeLblofMIFUsAqoSkz79YgGx2QQMJaZu ms0IYosIaEnsOHkSbIWwgJzEzZtfwOK8AvYS91//YQOxOQWCJfaefQ41dBmjxJwLU8Ea+AX0 Ja7+/QR1n73EzCtnoJoFJX5Mvge2jBloweZtTawQtrzE5jVvmSHOVpe4cXc3+wRG4VlIWmYh aZmFpGUBI/MqRpHU0uLc9NxiI73ixNzi0rx0veT83E2MwDjaduznlh2MXe+CDzEKcDAq8fDO yD4YIcSaWFZcmXuIUYKDWUmEV7b0UIQQb0piZVVqUX58UWlOavEhRlNgyExklhJNzgfGeF5J vKGJobmloZGxhYW5kZGSOO/UD1fChQTSE0tSs1NTC1KLYPqYODilGhjla388don9qjRR/jtv VOOUpuCrMoIV9z+tWL6+Tq7tZYnmpin/jr1f/Fhv2ZNIVq5cpsqPrznZ7S1mRF+M3B3atdvw rsY5vZYGs9Nrtrsfk/Bs0f6UU8S3zPWy3luVlUGtlpzxW/Js/TkPh1wxWdwTHXJF/KqzRl+p 5hvu/6bG70o7buWwOyqxFGckGmoxFxUnAgDyQFLxuQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170310094639eucas1p1248c012558b0c40090e28e7f243e0dae X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170310072841epcas2p2340dcec5f380c88168d615f3df3de89d X-RootMTR: 20170310072841epcas2p2340dcec5f380c88168d615f3df3de89d References: On Thu, 9 Mar 2017 23:27:36 -0800 Bart Schaefer wrote: > glob.c:2398:10: warning: comparison of constant -101 with expression of type > 'unsigned char' is always false > [-Wtautological-constant-out-of-range-compare] > if (IS_DASH(c1) && lastch >= 0 && p < str2 && lastch <= (int)c2) { > ^~~~~~~~~~~ > ./zsh.h:248:39: note: expanded from macro 'IS_DASH' > #define IS_DASH(x) ((x) == '-' || (x) == Dash) > ~~~ ^ ~~~~ > > (It's complaining about the comparison to Dash if proportional font > misplaces the caret.) I presume I'm not going to see this warning anyway, but Dash is cast to char so the only obvious thing to do is cast c1, which is currently unsigned. Alternatively, IS_DASH could be even more clumsy with casts to both Dash and the input character to unsigned. pws diff --git a/Src/glob.c b/Src/glob.c index 87127e1..0fcb4e1 100644 --- a/Src/glob.c +++ b/Src/glob.c @@ -2395,7 +2395,8 @@ xpandbraces(LinkList list, LinkNode *np) c2 = ztokens[c2 - STOUC(Pound)]; if ((char) c2 == Meta) c2 = 32 ^ p[1]; - if (IS_DASH(c1) && lastch >= 0 && p < str2 && lastch <= (int)c2) { + if (IS_DASH((char)c1) && lastch >= 0 && + p < str2 && lastch <= (int)c2) { while (lastch < (int)c2) ccl[lastch++] = 1; lastch = -1;