From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Extend (z) test with data that seemed to cause fail
Date: Fri, 10 Mar 2017 10:57:48 +0000 [thread overview]
Message-ID: <20170310105748.70221f05@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <170309203551.ZM30471@torch.brasslantern.com>
On Thu, 9 Mar 2017 20:35:51 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 9, 10:05am, Peter Stephenson wrote:
> } Subject: Re: [PATCH] Extend (z) test with data that seemed to cause fail
> }
> } I've turned the file text into printable characters like this.
>
> There are a bunch of similar unprintable characters in V11db_gdbm
> if you would like to have a go at that, too.
The only non-ASCII characters I can see are UTF-8 characters which show
up fine on my system. They may or may not show up properly here:
漢字
They are Unicode characters 0x6f22 and 0x5b57.
I don't think it's worth hacking these into \u sequences, particularly
as it makes comparing the output more difficult. We already need to
edit D07 in UTF-8 mode; a note should be good enough.
As they're not being treated as characters I don't think it matters
if they're not valid in other locales, either. Or, to put it another
way, that would be a bug we ought to fix.
pws
diff --git a/Test/V11db_gdbm.ztst b/Test/V11db_gdbm.ztst
index 02bdae2..6d74cef 100644
--- a/Test/V11db_gdbm.ztst
+++ b/Test/V11db_gdbm.ztst
@@ -1,4 +1,6 @@
-# Tests for the zsh/param/private module
+# Tests for the zsh/db/gdbm module.
+# This contains literal UTF-8 characters; if editing, use
+# UTF-8 mode.
%prep
prev parent reply other threads:[~2017-03-10 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170309082643epcas1p442c9a88050e6607dc8eeb9e9138e8068@epcas1p4.samsung.com>
2017-03-09 8:16 ` Sebastian Gniazdowski
2017-03-09 10:05 ` Peter Stephenson
2017-03-09 11:32 ` Sebastian Gniazdowski
2017-03-09 11:49 ` Peter Stephenson
2017-03-10 4:35 ` Bart Schaefer
2017-03-10 10:57 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310105748.70221f05@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).