From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19753 invoked by alias); 25 Mar 2017 10:17:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40899 Received: (qmail 28438 invoked from network); 25 Mar 2017 10:17:44 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-0.7/5.0):. Processed in 1.966739 secs); 25 Mar 2017 10:17:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=y+7+5RkjmtviekFzzLLgwmr6V08qFjeCGC5KxSS7Ko0=; b=dQnPMhDv 6I5UU7VWgL0Z3TX7tmsuW5M7HMufrGL/AJOoseW03a5zEkn2iE4KdJRq6WSTQCTX 2JurXxr+pP86vNbRECfUrZ+fACXD/pl+1p9QdGBwKpiEw3LFWs3fSRdAamv2U4Au vXc5SHVbKLocNBcETUu4f+u2PR1KqgHpN/GRXtZ/y26U4hWjxKRGQyK3ueiQ6vnw VKIiriZm9n3+QI75kAnL72BRpGEY+qUg0gmjaSbFd0G3zkAzTTORs2wl+laEVLFk 285lKess4VudzBpP3pVjgtlGXi1rDY00DfRWMvG9b+j27NnbrjTVUD8XYnaPvWb8 ANbiV4sYca2ZHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=y+7+5RkjmtviekFzzLLgwmr6V08qFjeCGC5KxSS7Ko0=; b=LTwJNDOj aNKW9LIn3SFrnQuqddE67M9uzpE5HLLjI5VDLgRQd6sgtZUVbOfc+b7+VPcaEUxk +nT9/ZIU7sYt49m+WtcMlcApsHBU+v2snog2noyS0+praXdTaaq0D7fC4C8VJ+Ax j0kJ1vYXpIT4CCqGaiHnHPPAhhzrGkdCgZeo21oLlL0p6Fj0DoiljmMRE0FhcvsJ ffchpRp5gDCPudtlKgXX8glvFaoGDsSLLOpPt7T/uWI2YF8H67MKEN0Jt9lmmKJH wVo1QzvyWRuoNSCt0Kx2y6tMVzwal0mqzpz4gi7LuTDjOG6PGAhaAGXz0ODj3RXM 65MZwYEcZuKE2w== X-ME-Sender: X-Sasl-enc: h3nOhLjPIQUBmzxQsfC+xdDxHRsT/uH8riRY88CVT+c1 1490437055 Date: Sat, 25 Mar 2017 10:12:25 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] Use gdbm_errno with gdbm_open Message-ID: <20170325101225.GA3785@fujitsu.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sebastian Gniazdowski wrote on Sat, Mar 25, 2017 at 07:55:54 +0100: > +++ b/Src/Modules/db_gdbm.c > @@ -154,12 +154,13 @@ bin_ztie(char *nam, char **args, Options ops, UNUSED(int func)) > +    gdbm_errno=0; Nitpick: whitespace around assignment operator. >      dbf = gdbm_open(resource_name, 0, read_write, 0666, 0); >      if(dbf) { >   addmodulefd(gdbm_fdesc(dbf), FDT_MODULE); >          append_tied_name(pmname); >      } else { > - zwarnnam(nam, "error opening database file %s", resource_name); > + zwarnnam(nam, "error opening database file %s (%s)", resource_name, gdbm_strerror(gdbm_errno)); How about "error opening database file '%s'; gdbm error: %s" ? That is: add quotes, avoid parentheses around pertinent information, and sign gdbm's error message. (I'd have used %q as in printf(1), but I don't think zerrmsg() supports that yet.) Cheers, Daniel