From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19059 invoked by alias); 9 Apr 2017 15:33:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40943 Received: (qmail 11832 invoked from network); 9 Apr 2017 15:33:55 -0000 X-Qmail-Scanner-Diagnostics: from hahler.de by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(188.40.33.212):SA:0(0.0/5.0):. Processed in 1.85846 secs); 09 Apr 2017 15:33:55 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: daniel@hahler.de X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.hahler.de designates 188.40.33.212 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thequod.de; h= x-mailer:message-id:date:date:subject:subject:from:from:received :received:received; s=postfix2; t=1491751423; bh=eD+mFRaD3X3dbko fmweWFPU4LGkH/S7P+yb114Gjo2A=; b=eEQyPLrbKH/aqXTPFe1NKwi25mbm/Pe jg2QvDUpO8CG5c8oGgoojSiXCKJqH2/AARqt9Jkyx+nsz1YuQ92Taftfg5UfOd52 gZoMCo747zlOsDoQ65OSXdysYLkAaaZoU9/vvIRLuA+OQtYvaJRyB5jUO4OsRNmY mSAp38KPQq5A= From: Daniel Hahler To: zsh-workers@zsh.org Subject: [PATCH] __git_recent_commits: prefer recent commit objects Date: Sun, 9 Apr 2017 17:23:35 +0200 Message-Id: <20170409152335.20372-1-genml+zsh-workers@thequod.de> X-Mailer: git-send-email 2.12.2 From: Daniel Hahler Without this "commit to be amended" shows up before "recent commit object name" with `git commit --fixup`, but the recent commit objects are the most useful here. RFC: Daniel Shahaf mentioned that `expl=()` might not be right here after all, so I am waiting for feedback before pushing it. --- Completion/Unix/Command/_git | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 85aac9264..a46e3b55d 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -6326,11 +6326,11 @@ __git_recent_commits () { ret=1 # Resetting expl to avoid it 'leaking' from one line to the next. expl=() + _describe -V -t commits 'recent commit object name' descr && ret=0 + expl=() _wanted commit-tags expl 'commit tag' compadd "$@" -a - tags && ret=0 expl=() _wanted heads expl 'head' compadd "$@" -a - heads && ret=0 - expl=() - _describe -V -t commits 'recent commit object name' descr && ret=0 return $ret } -- 2.12.2