From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10216 invoked by alias); 26 Apr 2017 19:56:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41013 Received: (qmail 17672 invoked from network); 26 Apr 2017 19:56:07 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. Processed in 1.881614 secs); 26 Apr 2017 19:56:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=8FWyQSn7H7mdAPKWD2 LWfBbcpWtnZozlPz7HUCcZDPk=; b=lUXu+OX2BNhpp3NfdFRnw/VNmVYx/YRg5g o03GVOPAYIbUsWjVD0xFdQftJDeFkfWWitHoFtET4jiNXVE8CC4qmnr+3/tOT16z eu7G7lr1oOZFIqsUZp1K2RENFE92yKRX3qtmYEff6CqD75VmtSABfL212poz6Zq9 T2YSJJp3xiwzmID8AVDKKK/ryIrzoD9yemXq3QSkzim358FCRbzRovY6CahQgWCN UH1r0d/jtv4/+KxryAVsHFqLwtc3F5JziIYwRWiF6WZqdVUcA7U0JITOuY61bSAU wwJAoLP4NI/HMhvGa3aRq+xKhsPDU7vY0CR99P9ZqnG8g7KgfGQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=8FWyQSn7H7mdAPKWD2 LWfBbcpWtnZozlPz7HUCcZDPk=; b=Ql2WHJoMj0N6hnSTXeEx44DlAXiQqbvgAD 0VPJJjo1NIAbHuT46D8L7Cagy9xA+IMO4SBA8RBD9Jm3vjYTt1Y4fAfWwkdNC2h9 KQ9BL+SqTH7aHSU8biD2PLXJfwmfmWgUrnYWRZa5pAN9cMmSOBPIYUXMji4/3Ago SnVx29D6BTxkuQEh69gxPEn6HUuxnP0/8CGHjcoL2E7fy9M0JyFW45E4d3Sg5aD6 EfhByTzpDKQZlQhYLMJGs5feumYNAqU3o3cD2Zxr/wg4pY+AiYkUeFvhabiDUrlB Xa2bionnfHFunZpGsKm8tLiImLy1aPPDFnYg4vLrAij8+dk7qmnA== X-ME-Sender: X-Sasl-enc: HTHKvguvTCcKxis/dB9kFdE/koEeUxPSa/qz6X5bGVu9 1493235918 Date: Wed, 26 Apr 2017 19:45:17 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: PATCH: perform expansion for precommand modifiers Message-ID: <20170426194517.GA12961@fujitsu.shahaf.local2> References: <20170425101520.23910ede@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170425101520.23910ede@pwslap01u.europe.root.pri> User-Agent: Mutt/1.5.23 (2014-03-12) Peter Stephenson wrote on Tue, Apr 25, 2017 at 10:15:20 +0100: > This is something I've been meaning to get around to for a while. > "exec" and "command" have a for quite a long time now taken options, > but the parsing hadn't caught up properly so that it wasn't possible to > put the options, let alone the modifiers themselves, in a parameter. > This fixes both --- see the new tests. Is this worth a NEWS entry? (not README since the change is backwards compatible) diff --git a/NEWS b/NEWS index 5479251..4b5e12a 100644 --- a/NEWS +++ b/NEWS @@ -4,5 +4,15 @@ CHANGES FROM PREVIOUS VERSIONS OF ZSH Note also the list of incompatibilities in the README file. +Changes from 5.3.1 to 5.4 +------------------------- + +The 'exec' and 'command' precommand modifiers, and options to them, are +now parsed after parameter expansion. Previously, both the modifier +and any options to it were only recognised if they had already been +present in the command line before any parameter references were expanded. +Example: 's=command; $s -V ls' now works as expected. + + Changes from 5.2 to 5.3.1 -------------------------