zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Cannot paste unicode <0221>, <0234> - <024f>
Date: Fri, 28 Apr 2017 15:41:35 +0100	[thread overview]
Message-ID: <20170428154135.2e2b5626@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <etPan.5903498f.140e0f76.15fbc@MacMini.local>

It might be possible to rely *only* on wcwidth() in cases where we're
using a replacement?  Does anyone from the Apple world have any
opinions?

pws

diff --git a/Src/Zle/zle_refresh.c b/Src/Zle/zle_refresh.c
index 8391739..d0384af 100644
--- a/Src/Zle/zle_refresh.c
+++ b/Src/Zle/zle_refresh.c
@@ -1278,7 +1278,15 @@ zrefresh(void)
 #ifdef __STDC_ISO_10646__
 		 !ZSH_INVALID_WCHAR_TEST(*t) &&
 #endif
-		 iswprint(*t) && (width = WCWIDTH(*t)) > 0) {
+		 /*
+		  * If we are using a replacement wcwidth(), rely
+		  * on it also for checking printability: width <= 0
+		  * if not printable.
+		  */
+#ifndef BROKEN_WCWIDTH
+		 iswprint(*t) &&
+#endif
+		 (width = WCWIDTH(*t)) > 0) {
 	    int ichars;
 	    if (width > rpms.sen - rpms.s) {
 		int started = 0;


  parent reply	other threads:[~2017-04-28 14:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170428111102epcas3p1cc3d86dc54fdafd8cd0e613bbaeba69b@epcas3p1.samsung.com>
2017-04-28 10:55 ` Sebastian Gniazdowski
2017-04-28 11:44   ` Peter Stephenson
2017-04-28 12:11     ` Sebastian Gniazdowski
2017-04-28 13:16       ` Peter Stephenson
2017-04-28 13:54         ` Sebastian Gniazdowski
2017-04-28 14:10           ` Peter Stephenson
2017-04-28 14:41           ` Peter Stephenson [this message]
2017-04-28 15:27             ` Sebastian Gniazdowski
2017-04-28 15:43               ` Peter Stephenson
2017-04-28 16:11                 ` Sebastian Gniazdowski
2017-04-29  6:39             ` Sebastian Gniazdowski
2017-05-01  2:53               ` Jun T.
2017-05-01 15:52                 ` Jun T.
2017-05-02 13:15                   ` Peter Stephenson
2017-05-06 15:58                   ` Sebastian Gniazdowski
2017-05-06 18:11                     ` Bart Schaefer
2017-05-07  9:50                       ` Sebastian Gniazdowski
2017-05-08  2:44                         ` Daniel Shahaf
2017-05-08  4:04                           ` Gmail patch extraction (was: Cannot paste unicode <0221>, <0234> - <024f>) Sebastian Gniazdowski
2017-05-08  4:33                             ` Sebastian Gniazdowski
2017-05-08 11:07                               ` Daniel Shahaf
2017-05-06 18:39                     ` Cannot paste unicode <0221>, <0234> - <024f> Daniel Shahaf
2017-05-07 10:13                   ` Sebastian Gniazdowski
2017-05-10 11:29                   ` Jun T.
2017-05-12  7:50                     ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428154135.2e2b5626@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).