From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28364 invoked by alias); 29 Apr 2017 17:07:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41032 Received: (qmail 15131 invoked from network); 29 Apr 2017 17:07:13 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. Processed in 2.465532 secs); 29 Apr 2017 17:07:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=mL7X1T94+ZmQBjRbqWuwkaPn18Xhc9ObyGoRxSuN89k=; b=qZPGg6pd aGATYCpb1fQA4OhhJZZBvWKnjhklr4J6A7oo1VaZrvglNct8xdiAWLCiBBNZTiYe 1mo40Z3SSQY6IrQOzd5445qHhj0KlWhbNSE2nl0eUAm8CMkyo7hSqsDfj2F7hcJw T7RPJh5GtsqxJy7IL8Zd9cZ5mah7mWm6+gUAUmeOJqh+lSErrjStZY62XvmF4BRz SjXuODylps7sXc51OreByJzj2AzzsZY3u+AT9zNz0TadrDkzLCB/ienRYARPSsBv hZQ2zq4U6pY7zU4WD3sbXo4FhwN4MGKMm9TgvZRXAFMcyAtI8Wn5zxBrH8VCFW9G 12YogHVd5dHmnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=mL7X1T94+ZmQBjRbqWuwkaPn18Xhc9ObyGoRxSuN89k=; b=UnNm/DQH WQSDQGYWrF8Q4jI0BMo2Ec8rPw3D/sgkXYjkD374cx1CQ3Yjv4GJj9o0SO44tC5b wfoC/Ti1VvbdMKFfemS6utR3vDpTZdhOautdt89Jx2iZ1rf/rDetM2ryJ1PvNXcb 8kyaKTj/us3rHRV0err72DjnNeIHCDEkzUzNas+RLNrDAdF3EwP9340tO5ILixQR PszH9/QevXLlkCJfmxbakW7EF1WDNNIDV0WAhPnoI5+YXAXoSV7Eg59Ola/95gD/ VzoanUXJq73XcSN1BcMpD1eoceHlnS1uOtrKk/6Or3yK7rvkm8BJKIICGHbVSKws r57tK4vrTkLxsg== X-ME-Sender: X-Sasl-enc: Mr9KThxTAaGWJRauCjtlRN9zR9J+8FZk5NN3SVyjnKmU 1493485623 Date: Sat, 29 Apr 2017 17:07:00 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] Functions/Misc/relative: use -q with cd Message-ID: <20170429170700.GA14300@fujitsu.shahaf.local2> References: <20170427203537.13535-1-genml+zsh-workers@thequod.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170427203537.13535-1-genml+zsh-workers@thequod.de> User-Agent: Mutt/1.5.23 (2014-03-12) Daniel Hahler wrote on Thu, Apr 27, 2017 at 22:35:37 +0200: > +++ b/Functions/Misc/relative > @@ -8,8 +8,8 @@ emulate -L zsh || return 1 > -1=$(cd $1; pwd -r) > -2=$(cd $2; pwd -r) > +1=$(cd -q $1; pwd -r) > +2=$(cd -q $2; pwd -r) Would «1=${1:P}» be equivalent? (If it is, it saves a fork.) Pre-existing problem: should the function check that cd succeeded? It already checked that $1 and $2 exist, but they might be unreadable/unexecutable by the EUID.