From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Cc: Jan Kryl <jan.kryl@nexenta.com>
Subject: Re: autocompletion is broken in restricted shell
Date: Mon, 08 May 2017 17:48:47 +0100 [thread overview]
Message-ID: <20170508174847.6fe6b571@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <11381B06-E104-4785-8BB7-AC5E5B0296F0@nexenta.com>
On Mon, 8 May 2017 11:38:37 +0200
Jan Kryl <jan.kryl@nexenta.com> wrote:
> However at least I would like to fix another thing which breaks
> autocompletion and that is using write redirections in autocompletion
> code. That can be avoided by using 2>&- instead of 2>/dev/null. A
> patch for review is attached.
Hmmm... I'm not sure if this is deliberate, to minimise the chance of
errors. But, as discussed elsewhere, we ignore write errors on
descriptors a lot of the time anyway, so I'm not sure it matters... and
I'm not sure if you're realistically going to get an error message from
there as long as the shell supports that syntax, so it's probably
reasonable to apply this and see what happens.
pws
next prev parent reply other threads:[~2017-05-08 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170508093906epcas5p35e1b5c235b94e4b754107d42c915e638@epcas5p3.samsung.com>
2017-05-08 9:38 ` Jan Kryl
2017-05-08 16:48 ` Peter Stephenson [this message]
2017-05-08 18:03 ` Bart Schaefer
2017-05-10 5:02 ` Bart Schaefer
2017-05-10 8:48 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508174847.6fe6b571@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=jan.kryl@nexenta.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).