From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6093 invoked by alias); 25 Jul 2017 14:11:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41458 Received: (qmail 7277 invoked from network); 25 Jul 2017 14:11:58 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-0.7/5.0):. Processed in 1.979095 secs); 25 Jul 2017 14:11:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=q3o0wW XAygPCdu/ZRbLWM1pqb0exteNVu1bAkQN24mg=; b=mI9rzB/BlkRwNiyhd953l9 X2nVwhPCZ8SYnaWUanunJyq1zDtQWHqhmElSW3LrEr9IGkq94LlPNg6jeTLlvwXw P1L5NlkyiwxMnRcdTDTZYJFZ+DjOf3hluaACw5XeyDqmz0kvn4q8VfLPXlD5Vp3A /MUjABrETPPCLIbg5p6Tch6nC/BF0SHX/1jwD3nxHa3ZZ8P2mb1WvO+xyd2F1z8i /a4UR291OdoWOJAXhfzSFQw2EC3uauJrMXU2SXeQ0DiI59ojrslisjLWEekP0olO mHQK5rM6ZNfAyxfaLXqNQBkw0JimsQ0uknEVMOvOesJEFbZEJers8U2Q3e6nk5oA == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=q3o0wW XAygPCdu/ZRbLWM1pqb0exteNVu1bAkQN24mg=; b=nwuyNnxH9y+vJSM+v4fYiT abHMpQnFOZ8wM45Zaea/kaYKbznoX+N0OSAdZn/IUhmY2cWT3qQWhvkSS7zW/zcp AMsU95CqyB1D6OEr2gB/1EXnmjUJswZOB4F7boWQ3t80dAk8kH6KgYB+r+4zctkG /E46gPWrvUjT99cBq+DlOlpy/YDvGdRswUr/WTxPIJ1U0xONk2r04QQMTG41NFpd nL2jx9CkPT5GjaomIcFQiZhdZbCr6zPnCH/Bkst6mvU6EEoH2iR0q1YweX6ydOni 4le6r6gCoKfjWtRHtenl787fHgni4GBzH7oRq1Qv3t+8pt5zBswildn1BVBMRaXg == X-ME-Sender: X-Sasl-enc: XEXwnsJs9h4vuQLaF/YTAAip0FWPvTlYRA64l7y3Y7Yj 1500991912 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: [PATCH] _subversion: Don't cache an empty commands list when svn is not available at the first invocation of _svn. Date: Tue, 25 Jul 2017 14:11:49 +0000 Message-Id: <20170725141149.28147-1-danielsh@tarpaulin.shahaf.local2> X-Mailer: git-send-email 2.11.0 --- This affects the following use-case: % svn ^C % ${PACKAGEMANAGER} install subversion % svn Before the patch it would cache the "No matches", with the patch it invokes svn again. Cheers, Daniel Completion/Unix/Command/_subversion | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Completion/Unix/Command/_subversion b/Completion/Unix/Command/_subversion index 640c88950..2f6b567ac 100644 --- a/Completion/Unix/Command/_subversion +++ b/Completion/Unix/Command/_subversion @@ -36,7 +36,12 @@ _svn () { _svn_cmds=( ${=${(f)${${"$(_comp_locale; _call_program commands svn help)"#l#*Available subcommands:}%%Subversion is a tool*}}/(#s)[[:space:]]#(#b)([a-z]##)[[:space:]]#(\([a-z, ?]##\))#/$match[1] :$match[1]${match[2]:+:${${match[2]//[(),]}// /:}}:} ) - _store_cache svn-cmds _svn_cmds + if (( $? == 0 )); then + _store_cache svn-cmds _svn_cmds + else + # Ensure we enter this block again on the next . + unset _svn_cmds + fi fi fi