From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1087 invoked by alias); 11 Aug 2017 17:18:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41531 Received: (qmail 15951 invoked by uid 1010); 11 Aug 2017 17:18:39 -0000 X-Qmail-Scanner-Diagnostics: from mx.spodhuis.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(94.142.241.89):SA:0(-2.3/5.0):. Processed in 2.506968 secs); 11 Aug 2017 17:18:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: zsh-workers+phil.pennock@spodhuis.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d201708; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nrAmF8gkKp5eOX9GEOaNAfHHMW32Yj3JssGqG0iAgog=; b=NrIsYlAiBjvr1yyefRPxVesicz aQ60nhwcBN4rU9j/4/o7Sv8nmeLdG4a5KpyRjVoaSoVqiveUTyoYRKN9qxBBfHHdbNDSEotMWSAXA Y34EHMZeEX6AAYt20Aqm44ckjbDNsch5BMW4eIcrXFVpzJqx8gLU+3ItZC7/W++IVTcIbdoRzl0st BtakljBN9z+fiG5+7rkefcYgBAM9; Date: Fri, 11 Aug 2017 13:18:27 -0400 From: Phil Pennock To: Peter Stephenson Cc: Zsh hackers list Subject: Re: [PATCH] repair conds where - within cond name Message-ID: <20170811171827.GA62807@tower.spodhuis.org> References: <86221c7e-aa71-28a7-21c2-8ed800090edd@bureaucracy.de> <20170811010701.GA94571@tower.spodhuis.org> <20170811013649.GA95238@tower.spodhuis.org> <20170811020246.GA718@breadbox.private.spodhuis.org> <20170811093133.2ff7c1b0@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170811093133.2ff7c1b0@pwslap01u.europe.root.pri> OpenPGP: url=https://www.security.spodhuis.org/PGP/keys/0x4D1E900E14C1CC04.asc On 2017-08-11 at 09:31 +0100, Peter Stephenson wrote: > On Thu, 10 Aug 2017 22:02:46 -0400 > Phil Pennock wrote: > > + lookup = ztrdup(name); > > I'd be inclined just to put this on the heap. I can do that myself if > that's OK. I'm guessing you meant stack, or some short-lived pool. I couldn't remember the means to do that in zsh and brief looking didn't help, so I went with what worked. "Yes" is the answer. Go ahead. I could switch a bunch of memory stuff in the PCRE/regex libs over to the same too, at the same time as adding tests, if I manage to get some spare time. This one is nagging at me right now, so it might happen. -Phil