zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Comment (# char) behavior in the sub-shell
Date: Mon, 11 Sep 2017 10:42:39 +0100	[thread overview]
Message-ID: <20170911104239.44911443@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20170911094926.5d8dc355@pwslap01u.europe.root.pri>

On Mon, 11 Sep 2017 09:49:26 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> Your patch could possibly do the right thing, as it hits the simpler
> part of the test and shouldn't affect behaviour other than comments, so
> it might be worth trying for now.

(Paranoia.)

I see, however, "nocomments" isn't saved and restored as we enter
different levels of reading history, which could be a problem.  But I
don't think so --- you're just modifying around *parsing* a string, not
execution of the result, so there's no possibility of the effect being
passed on where it shouldn't be.

Is there?

[The sombre background music to this post is available at all online
retailers.]

pws


  reply	other threads:[~2017-09-11  9:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 16:33 Stanislav Seletskiy
2017-09-09 22:46 ` Bart Schaefer
2017-09-10 20:06 ` Peter Stephenson
2017-09-10 21:24   ` Stanislav Seletskiy
2017-09-10 22:27   ` Bart Schaefer
2017-09-11  8:49     ` Peter Stephenson
2017-09-11  9:42       ` Peter Stephenson [this message]
2017-09-20 11:54         ` Stanislav Seletskiy
2017-09-20 17:16           ` Bart Schaefer
2017-09-21  4:43             ` Stanislav Seletskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911104239.44911443@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).