From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18332 invoked by alias); 29 Sep 2017 15:36:37 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41791 Received: (qmail 17959 invoked by uid 1010); 29 Sep 2017 15:36:37 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-6.9/5.0):. Processed in 2.184404 secs); 29 Sep 2017 15:36:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-AuditID: cbfec7f2-f793b6d000003243-79-59ce687e3816 Date: Fri, 29 Sep 2017 16:36:27 +0100 From: Peter Stephenson To: "zsh-workers@zsh.org" Subject: Re: Crash when completion script call itself. Message-id: <20170929163627.567759ce@pwslap01u.europe.root.pri> In-reply-to: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djPc7r1GeciDRY8Y7Y42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGQvvT2cpWM5Z8eGhSgPjJvYuRk4OCQETiaWvpkDZYhIX7q1n A7GFBJYySmxtquhi5AKye5kkjq3aBtcwd+tZFojEMkaJNVffM0J0TGOS+PHAGiJxhlHi+/+p jBDOWUaJ12s3MYFUsQioSmz89ZMZxGYTMJSYumk2WLeIgL7ExT+3wGxhATOJrvMLwGp4Bewl Xne/AlvNKRAs8enOS7D7+IHqr/79xARxkr3EzCtnGCHqBSV+TL7HAmIzC+hIbNv2mB3ClpfY vOYtM8hBEgJz2CR2zT4MNIgDyHGR+PKpGGKOsMSr41ug3pSR6Ow4CDW/n1HiSbcvRO8MRonT Z3awQSSsJfpuX2SEWMAnMWnbdGaImbwSHW1CEKaHxL4WU4hqR4krZ2awQcLkB5NEw/9+pgmM CrOQnD0LydmzkJy9gJF5FaNIamlxbnpqsbFecWJucWleul5yfu4mRmASOP3v+KcdjF9PWB1i FOBgVOLhbfA4FynEmlhWXJl7iFGCg1lJhLcgHSjEm5JYWZValB9fVJqTWnyIUZqDRUmc1zaq LVJIID2xJDU7NbUgtQgmy8TBKdXAuETBWebIzSv8/3X/LuJd0xxhxr9jyV5/gyoXa9vyzf/l GOfsfrxq/4tmr77y9FdXfDwrhSet7ZErefqscd6pfoNrl5ZlTHlUYXy3y8W7zjt+B9+/TxcY H2buNJuWqLlB9vUdw9d7H85r6tydKDrNX5ND4uGiXY5238Ut/b9KPbidW/SL62K5mRJLcUai oRZzUXEiAINKMNb+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xq7p1GeciDRaflrI42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGQvvT2cpWM5Z8eGhSgPjJvYuRk4OCQETiblbz7JA2GISF+6t Z+ti5OIQEljCKLFrzzlmCGcGk8S0LfPAOoQEzjFKPNgdBZE4yygx98cEZpAEi4CqxMZfP8Fs NgFDiambZjOC2CIC+hIX/9wCs4UFzCS6zi8Aq+EVsJd43f0KbCinQLDE1AWdUKt/MUnsbTzI BJLgB2q++vcTE8R99hIzr5xhhGgWlPgx+R7Y3cwCWhKbtzWxQtjyEpvXvGWGuFRd4sbd3ewT GIVnIWmZhaRlFpKWBYzMqxhFUkuLc9Nziw31ihNzi0vz0vWS83M3MQKDeduxn5t3MF7aGHyI UYCDUYmHt8HjXKQQa2JZcWXuIUYJDmYlEd6CdKAQb0piZVVqUX58UWlOavEhRmkOFiVx3t49 qyOFBNITS1KzU1MLUotgskwcnFINjOaJ9yOFwuovP7wr8/alxz1v6/C/c9cl337mayEpk/BA 7H8612bDGYq3t4n6nDJ4N2NNj6FB3L084ZKt94JWaG3UK1Tcd6lut+dvu5/np1VtWTHPasnj j2vXNUxnu3vm0uH2d4xL3VoXfBDbV1C27PYftjuni2IYuI5s+/bvQwaHSYjNHI1NLxOUWIoz Eg21mIuKEwEA+lfAYgIAAA== X-CMS-MailID: 20170929153630eucas1p291ff7d45ce8576e8a014cd84f8779ccc X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-CMS-RootMailID: 20170929072715epcas1p4171c28e9b82f94d79796ecca7e564ec3 X-RootMTR: 20170929072715epcas1p4171c28e9b82f94d79796ecca7e564ec3 References: <20170929121008.3da15b34@pwslap01u.europe.root.pri> <4913136.yYypKkW7sH@kdudka-nb> <20170929151614.56fd9cff@pwslap01u.europe.root.pri> On Fri, 29 Sep 2017 08:22:16 -0700 Bart Schaefer wrote: > Philosophically speaking, the value of 1000 for max depth was also > based on user experience, and one might expect that most environments > now have more stack space available than they did many years ago when > 1000 was chosen. So reducing this value might make it more likely > that people will encounter the "depth exceeded" error. I think what's actually happened is we're saving and restoring rather more stuff. > At the least > the error message should be updated to mention increasing FUNCNEST ? I can certainly do that. > With respect to the #ifdefs, I think entirely removing FUNCNEST is a > bad idea -- it should remain so that its value can be examined. We > could go so far as to mark it readonly if preventing it from being > reset is the intention. I guess that affects whether the shell keeps > track of the current depth, too, but that doesn't seem like much > overhead. That was the intention but it escaped in one place --- the only remaining place should be where FUNCNEST gets initialised to -1 if the configuration parameter was undefined. pws