From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [bug] sh: tilde expansion after field splitting
Date: Mon, 09 Oct 2017 09:44:51 +0100 [thread overview]
Message-ID: <20171009094451.1334c863@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <171008134514.ZM12272@torch.brasslantern.com>
On Sun, 8 Oct 2017 13:45:14 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> } > - There either isn't a Test/ for the keyvalpairelement() case in the
> } > first hunk below, or it isn't rigorous enough, because I initially
> } > forgot the incnode(node) in that hunk, yet the shell did *not* go
> } > into an infinite loop during "make check", nor did any test
> } > fail
> }
> } That doesn't make sense.
>
> I don't know what to tell you; I just now commented it back out and tried
> again, and it still works. I suspect what's happening is that after the
> first call to keyvalpairelement() node = insnode is done, and then we
> continue around the loop and call keyvalpairelement() a second time on
> the same node, at which point it fails and we fall through the rest of
> the loop and hit the incnode() at the end, which fixes things.
Yes, that's it --- the key / value pair is turned into a Marker, key,
value list triad, and furthermore the key and value are untokenised as
no more substitution is wanted. So it'll just go striaght through.
This doesn't indicate a problem.
pws
next prev parent reply other threads:[~2017-10-09 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 22:20 Martijn Dekker
2017-10-05 5:24 ` Bart Schaefer
2017-10-08 7:53 ` Bart Schaefer
2017-10-08 19:20 ` Peter Stephenson
2017-10-08 20:45 ` Bart Schaefer
2017-10-09 8:44 ` Peter Stephenson [this message]
2017-10-13 9:43 ` Martijn Dekker
2017-10-13 12:55 ` Peter Stephenson
2017-10-13 15:36 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009094451.1334c863@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).