zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Cc: Julien Nicoulaud <julien.nicoulaud@gmail.com>
Subject: Re: GH:zsh-users/zsh-completions.
Date: Thu, 19 Oct 2017 14:37:36 +0000	[thread overview]
Message-ID: <20171019143736.uzln5hj62tydskkr@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <21335.1508343802@thecus.kiddle.eu>

[having trouble following everything in this thread; replying to just
one section]

Oliver Kiddle wrote on Wed, Oct 18, 2017 at 18:23:22 +0200:
> What I would prefer is for us to leave zsh completions where they are but
> optimise the workflow:
> 
>   * Encourage completion contributions in the form of github pull
>     requests to the zsh-users/zsh mirror. This isn't hard to handle:
>     add github as an additional remote, fetch refs/remotes/xxxx/pr/*,
>     cherry-pick and push to the sourceforge master.

Note that this is already happening: people sometimes submit pull
requests to zsh-users/zsh.  Some of us are subscribed to notifications
from that repository and handle such pull requests, either by fetching
them from github and pushing them to sourceforge as Oliver describes, or
by redirecting them to -workers@ for discussion and review.

Moreover, we could just as easily have both a github mirror and a gitlab
mirror and accept pull requests on both of them; all we need is some
maintainers (or this list) to subscribe to pull request notifications
from the gitlab mirror, and then to fetch pull requests from gitlab and
push them to sourceforge in the same manner as done for github.

>   * Require no mailing list message for basic completion updates.
>   * Rethink the need to update ChangeLog on every commit.

I think this is a subtly different issue, isn't it?  The "post to
-workers@" and "update ChangeLog" steps are only visible to the core
maintainer who integrates a change; they are not visible to the
contributor of the patch or to the end-users who consume it.

Cheers,

Daniel

> I realise that this doesn't solve the problems with how to hatch
> completions from zsh-completions.



  parent reply	other threads:[~2017-10-19 14:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7240.1507973844@thecus.kiddle.eu>
2017-10-14 14:44 ` GH:zsh-users/zsh-completions Julien Nicoulaud
2017-10-14 16:49   ` GH:zsh-users/zsh-completions Eric Cook
2017-10-16 14:29   ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-16 15:11     ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 15:24       ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-16 15:42         ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 17:49           ` GH:zsh-users/zsh-completions gi1242+zsh
2017-10-17 21:09             ` GH:zsh-users/zsh-completions Joey Pabalinas
2017-10-18 16:23               ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-19  1:09                 ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-19  4:03                   ` GH:zsh-users/zsh-completions Aaron Schrab
2017-10-19  5:24                     ` GH:zsh-users/zsh-completions Bart Schaefer
2017-11-01 23:33                   ` ChangeLogs (Re: GH:zsh-users/zsh-completions.) Oliver Kiddle
2017-11-01 23:46                     ` Bart Schaefer
2017-11-02 20:09                       ` Oliver Kiddle
2017-10-19  1:31                 ` GH:zsh-users/zsh-completions Joey Pabalinas
2017-10-19 14:37                 ` Daniel Shahaf [this message]
2017-10-30 23:38                   ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-11-01 16:35                     ` GH:zsh-users/zsh-completions Daniel Shahaf
2017-11-01 22:58                       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-16 23:00           ` GH:zsh-users/zsh-completions Bart Schaefer
2017-10-16 20:04       ` GH:zsh-users/zsh-completions Daniel Shahaf
2017-10-17  7:53       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-17  8:41         ` GH:zsh-users/zsh-completions Peter Stephenson
2017-10-16 15:26     ` GH:zsh-users/zsh-completions gi1242+zsh
2017-10-17  9:35       ` GH:zsh-users/zsh-completions Oliver Kiddle
2017-10-19 18:25         ` GH:zsh-users/zsh-completions Daniel Tameling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019143736.uzln5hj62tydskkr@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=julien.nicoulaud@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).