From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28199 invoked by alias); 20 Oct 2017 09:48:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 41942 Received: (qmail 9311 invoked by uid 1010); 20 Oct 2017 09:48:18 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-6.9/5.0):. Processed in 1.98797 secs); 20 Oct 2017 09:48:18 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-AuditID: cbfec7ef-f79ee6d000003120-af-59e9c4dc464e Date: Fri, 20 Oct 2017 10:41:45 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] Make typeset -p1 work in combination with -m. Message-id: <20171020104145.55f5a6cf@pwslap01u.europe.root.pri> In-reply-to: <1508437451.2315004.1144515592.1A7F0262@webmail.messagingengine.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7djP87p3jryMNJiyV9riYPNDJgdGj1UH PzAFMEZx2aSk5mSWpRbp2yVwZSxY2cBeMJG7YsfTbywNjJc5uhg5OSQETCRePlzKDmGLSVy4 t56ti5GLQ0hgGaPE96vTmSCcXiaJp71X2GE6Jr/tR6jqmvoVypnGJLHqySQo5wyjxJ+V/ewQ zllGicVLVrGA9LMIqErcu9IKNotNwFBi6qbZjCC2iIC4xNm158FqhAWcJPb0TGIFsXkF7CWm zVwIVs8pECzx6vxqJhCbX0Bf4urfT0wQN9lLzLxyhhGiXlDix+R7YHOYBXQktm17zA5hy0ts XvOWGeQgCYEFbBJPOx+zQDS7SGz6fIwVwhaWeHV8C9SjMhKdHQehFvQzSjzp9oVonsEocfrM DjaIhLVE3+2LjBAb+CQmbZsOtIEDKM4r0dEmBFHiIXG86yAjhO0o0X5hAyskVC4xSRz/vZVx AqPCLCSHz0Jy+Cwkhy9gZF7FKJJaWpybnlpsqFecmFtcmpeul5yfu4kRmA5O/zv+fgfj0+aQ Q4wCHIxKPLwbLryIFGJNLCuuzD3EKMHBrCTCa7j/ZaQQb0piZVVqUX58UWlOavEhRmkOFiVx XtuotkghgfTEktTs1NSC1CKYLBMHp1QDo4q1Ew+r7PHyJ1It1mr3wj5mv08Pvjlv7/kj29cp qn2eN+Ww8vkXWSE3Vi+qn6Sa90lhyu0sk6/fr2fProz7uuxEtvl8886H0zaky/4MZPqwjuvw g3YV24/XPy36H3/yp5FQ6sqp+7i+brn50Ib72eu1P8Rznv57vYZ3fwO7x2feM7ev79GbqnhQ iaU4I9FQi7moOBEAoOLuDgMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xa7q3j7yMNHh118riYPNDJgdGj1UH PzAFMEZx2aSk5mSWpRbp2yVwZSxY2cBeMJG7YsfTbywNjJc5uhg5OSQETCQmv+1ng7DFJC7c Ww9kc3EICSxhlDi0+ykrSEJIYAaTxOYfGRCJc4wSd6ZPY4NInGWUaNjCC2KzCKhK3LvSyg5i swkYSkzdNJsRxBYREJc4u/Y8C4gtLOAksadnEthQXgF7iWkzF4LVcwoES3Qf/cwCseAKk8TX SdvAivgF9CWu/v3EBHGevcTMK2cYIZoFJX5Mvgc2lFlAS2LztiZWCFteYvOat8wQx6lL3Li7 m30Co/AsJC2zkLTMQtKygJF5FaNIamlxbnpusaFecWJucWleul5yfu4mRmAwbzv2c/MOxksb gw8xCnAwKvHwbrjwIlKINbGsuDL3EKMEB7OSCK/h/peRQrwpiZVVqUX58UWlOanFhxilOViU xHl796yOFBJITyxJzU5NLUgtgskycXBKNTAGzftxp1VEU6Du9Wydng/MfwV4boiy39Iomsyd sKjyJUtC4+aTSn+vn+0+8ofN+uSH1LrfFu0ybTJtukcnbY4SMrOXW/YlY1b3/yV69msM2VSf rk190CT+Q+FiXBeLx9e8Sq5L+anW9q7OUk3fhL1WbVkZO3v/xyWN7cb7v+smvQyXSSgze67E UpyRaKjFXFScCACe+fwlYgIAAA== X-CMS-MailID: 20171020094147eucas1p16f3567258c5062534347931dd520e811 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1ByaW5jaXBhbCBFbmdpbmVlciwgU29mdHdhcmU=?= X-Global-Sender: =?UTF-8?B?UGV0ZXIgU3RlcGhlbnNvbhtTQ1NDLURhdGEgUGxhbmUbU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtQcmluY2lwYWwgRW5naW5lZXIsIFNvZnR3YXJl?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDA1Q0QwNTAwNTg=?= CMS-TYPE: 201P X-CMS-RootMailID: 20171017182806epcas1p25cabca4be0c223080d6aa3b8fbd30055 X-RootMTR: 20171017182806epcas1p25cabca4be0c223080d6aa3b8fbd30055 References: <20171017182700.28303-1-danielsh@tarpaulin.shahaf.local2> <20171018093119.5c82eaa0@pwslap01u.europe.root.pri> <20171019144043.pjinc3niymb6ioh4@tarpaulin.shahaf.local2> <1508437451.2315004.1144515592.1A7F0262@webmail.messagingengine.com> On Thu, 19 Oct 2017 18:24:11 +0000 Daniel Shahaf wrote: > Daniel Shahaf wrote on Thu, 19 Oct 2017 14:40 +0000: > > Peter Stephenson wrote on Wed, Oct 18, 2017 at 09:31:19 +0100: > > > On Tue, 17 Oct 2017 18:27:00 +0000 > > > Daniel Shahaf wrote: > > > > The PRINT_INCLUDEVALUE codepath will now pass > > > > PRINT_LINE|PRINT_TYPESET|PRINT_INCLUDEVALUE; is that correct? > > > > > > Yes, as long as the resulting output makes sense the flag can be passed > > > through. > > > > Ack. I'll double check the output before pushing. > > There's an unwanted output change: > > before% typeset -m argv > argv=( ) > > after% typeset -m argv > array argv That can only be this chunk at the end of printparamnode() --- there's nowhere else where we deal with the value. So something you've done has changed the result of that first test. You'll probably just have to step through and look at what's happening here. pws if ((printflags & PRINT_NAMEONLY) || ((p->node.flags & PM_HIDEVAL) && !(printflags & PRINT_INCLUDEVALUE))) { zputs(p->node.nam, stdout); putchar('\n'); } else { if (printflags & PRINT_KV_PAIR) { if (printflags & PRINT_LINE) printf("\n "); putchar('['); } quotedzputs(p->node.nam, stdout); if (printflags & PRINT_KV_PAIR) printf("]="); printparamvalue(p, printflags); }