From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Sebastian Gniazdowski <psprint@zdharma.org>
Cc: zsh-workers@zsh.org
Subject: Re: Localize MATCH, MBEGIN, etc. in _zstyle and _globquals
Date: Sun, 29 Oct 2017 18:07:21 -0400 [thread overview]
Message-ID: <20171029220721.GA37711@tower.spodhuis.org> (raw)
In-Reply-To: <etPan.59f5be1b.1dad7c90.98a8@zdharma.org>
On 2017-10-29 at 12:40 +0100, Sebastian Gniazdowski wrote:
> I was searching for regex usage (=~) and didn't find anything
> meaningful (would replace with (#b) or (#m) so that e.g. default
> static build works fine). However found (#m) use and not defined local
> MATCH, MBEGIN, MEND. To not surprise user with overwriting his
> matching results, I've localized those parameters in two Zsh-related
> completions.
_main_complete localizes `match` already. So if we don't localize all
of them in the same place then we're risking inconsistency, no matter
what.
Anyone know of a good reason to not just localize _all_ of the =~
non-BASH_REMATCH variables in _main_complete so that they're always
isolated to the completion-system, if =~ or -regex-match or -pcre-match
is used within the completion system?
-Phil
next prev parent reply other threads:[~2017-10-29 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 11:40 Sebastian Gniazdowski
2017-10-29 22:07 ` Phil Pennock [this message]
[not found] ` <etPan.59f655ed.1f659851.98a8@AirmailxGenerated.am>
2017-11-02 19:09 ` Sebastian Gniazdowski
2017-11-02 19:57 ` Phil Pennock
[not found] ` <etPan.59fb7aea.497d9379.98a8@AirmailxGenerated.am>
2017-11-04 16:57 ` Sebastian Gniazdowski
2017-11-04 19:03 ` Bart Schaefer
2017-11-05 16:20 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029220721.GA37711@tower.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=psprint@zdharma.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).