zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: PATCH: update git completion
Date: Tue, 14 Nov 2017 12:29:58 +0000	[thread overview]
Message-ID: <20171114122958.73zg4bwepi4bzh6b@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <2290.1510605435@thecus.kiddle.eu>

Oliver Kiddle wrote on Mon, Nov 13, 2017 at 21:37:15 +0100:
> This brings git option completion up to 2.15.

Thanks.

> I also checked for other changes. git relink has gone at some point and
> git interpret-trailers was added. In the past, for custom formats, you
> needed git log --format=format:%... Now you can skip the format: part.
> 
> Completion for git tag/for-each-ref sort keys and formats is also
> improved.

Not specific for this patch, but in general, would you consider
splitting patches?  When the "add new options" and "improve existing
options" parts are mixed, they're harder to review.

Cheers,

Daniel


      reply	other threads:[~2017-11-14 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 20:37 Oliver Kiddle
2017-11-14 12:29 ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171114122958.73zg4bwepi4bzh6b@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).