Re: zsh generates invalid UTF-8 encoding in the history

[Vincent Lefevre <vincent@vinc17.net>]

Hi,

This is a bit old, but...

On 2016-10-07 10:01:37 -0700, Bart Schaefer wrote:
> On Oct 7, 10:57am, Vincent Lefevre wrote:
> } And how can one cleanly append history lines to a history file?
> } I was using "cat some_file >> ~/.zhistory", which seems to work,
> 
> It'll work as long as there are no 0x83 bytes in some_file.
> 
> To be completely safe, you need to do something like this:
> 
>   # Pass input file as $1, output as $2
>   append_plain_file_to_history_file() {
>       emulate -LR zsh
>       local -a entries
> 
>       # Implementation issue:  read -r ignores backslash-newline
>       # folding, but without -r embedded backslashes are stripped,
>       # which seems a bigger problem.  Fix up $entries later.
> 
>       IFS=$'\n' read -r -d '' -A entries <$1
>       (( $#entries )) || return
> 
>       # Must supply a file name here to set HISTSIZE and SAVEHIST
>       fc -pa /dev/null $#entries $(( SAVEHIST + $#entries ))
> 
>       while (( $#entries )); do
>           if [[ "$entries[1]" == *\\ ]]; then
>               entries[1,2]=( ${entries[1]%\\}$'\n'${entries[2]} )
>           else
>               print -S $entries[1]

There should be a -r option:

  print -r -S $entries[1]

otherwise \r yields a CR character.

>               shift 1 entries
>           fi
>       done
>       fc -A ${2:-$HISTFILE}
> 
>       # Reset SAVEHIST to avoid attempting to lock /dev/null
>       SAVEHIST=0	# fc -p makes this implicitly local
>   }

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)