From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 940 invoked by alias); 1 Dec 2017 09:20:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42064 Received: (qmail 6003 invoked by uid 1010); 1 Dec 2017 09:20:46 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-1.9/5.0):. Processed in 10.190708 secs); 01 Dec 2017 09:20:46 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171201092030euoutp015578cdf9c186cab472c68475c02e0013~8ISfumdaH0300703007euoutp01- DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1512120030; bh=W5QEUNBPvLf7mlon6D+2Omr+c/rw7w9jcgCz6jXM4d0=; h=Date:From:To:Subject:In-reply-to:References:From; b=W5SpIckaSxQO8zwOszGittUolsuScA7E/cJM3bBfbMwnh/mfeDcR1gGGqbKkZsybl AwhttHR4MFxFIrfd+c4upmvDOjcKDPjg3w5g4rIDF2eyazY7n6MDg7whkJORNZn5zD 2jQx8HorGyEwyOLCaAupz/S5aWOH0489VoUuwkOU= X-AuditID: cbfec7f4-f790c6d0000075d3-2d-5a211edd7280 Date: Fri, 01 Dec 2017 09:20:26 +0000 From: Peter Stephenson To: dana , zsh-workers@zsh.org Subject: Re: [PATCH] getopts: Accurately report '-x' or '+x' in error messages Message-id: <20171201092026.269c1dcb@pwslap01u.europe.root.pri> In-reply-to: <733779CE-86B9-4178-B38B-7E64390BB4C6@dana.is> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsWy7djP87p35RSjDLY+ELZoPbaayeJg80Mm ByaPR1u3sXmsOviBKYApissmJTUnsyy1SN8ugSvjwqx/7AVn2SrOzz/D1sA4ibWLkZNDQsBE 4tShGewQtpjEhXvr2boYuTiEBJYySsw9/5IRwvnMKPFybQsLTMe1Ga1gHUICyxglLq8rgSj6 xyhx9/UxqI7TjBK3Jy1lgXDOMEpcXfqUEaSFRUBVYtmm7WA2m4ChxNRNs8FsEQEdiRvrXjCD 2MICARI3t81nArF5BewlXm/6A7aaU8Ba4s+GzWA2v4C+xNW/n5ggTrKXmHnlDCNEvaDEj8n3 wGqYBTQltu5ezw5ha0s8eXeBFeQgCYEVbBJ3G2YwQzS7SKy6M48RwhaWeHV8CzQ0ZCQ6Ow5C LehnlHjS7QvRPINR4vSZHWwQCWuJvtsXGSE28ElM2jYdaCgHUJxXoqNNCML0kPh2yRei2lHi yZ1p0ADuY5RY8fgw2wRGhVlI7p6F5O5ZSO5ewMi8ilEktbQ4Nz212ESvODG3uDQvXS85P3cT IzA9nP53/MsOxsXHrA4xCnAwKvHwWggqRAmxJpYVV+YeYpTgYFYS4a1bABTiTUmsrEotyo8v Ks1JLT7EKM3BoiTOaxvVFikkkJ5YkpqdmlqQWgSTZeLglGpgTLuae6v03eQLn+aufL/LzYU9 x/hC2eVVK8//Ld8dsPQ5S9/zFPO/d3jPbeApar83p/7Kev5bD9ird5loT1jVfFnG2eDmr8lz TPMMnssuNZ7vq3gtYynvmTKhHyLHjht9EDISqK9Tuc209pmjebSGaIW/8NvGRTLVCmmeLDa3 fU+rnFXXXOYhqsRSnJFoqMVcVJwIAOAZM9cLAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t/xq7p35BSjDC68MbFoPbaayeJg80Mm ByaPR1u3sXmsOviBKYApissmJTUnsyy1SN8ugSvjwqx/7AVn2SrOzz/D1sA4ibWLkZNDQsBE 4tqMVnYIW0ziwr31bF2MXBxCAksYJT6eXsYK4TQwSaz+uRzKOc0o0Xp6DQuEc4ZRYuLV0ywg /SwCqhLLNm1nBLHZBAwlpm6aDWaLCOhI3Fj3ghnEFhbwk3j6bSOYzStgL/F60x+wXk4Ba4k/ GzZDDZ0AtLtrItiB/AL6Elf/fmKCONBeYuaVM4wQzYISPybfA2tmFlCXmDRvETOErS3x5N0F sF4hoPiNu7vZJzAKz0LSMgtJyywkLQsYmVcxiqSWFuem5xYb6hUn5haX5qXrJefnbmIEBvm2 Yz8372C8tDH4EKMAB6MSD+8EYYUoIdbEsuLK3EOMEhzMSiK8dQuAQrwpiZVVqUX58UWlOanF hxilOViUxHl796yOFBJITyxJzU5NLUgtgskycXBKNTBa3Fl0MCr02J6YvSrmjxf67GV718Sa KVjW4Ds7WlrRzzT92MRlJQqJ2aeXnDh4V+L6znMlpQnTJv/dwab1JOoAy6d5jAH7/ap2bX2a tKHmwsE73gHdF5x453Cxr3hvxTKRo+rRnYYOndszPu1jj3HbUeDqVMe9W+6qsxPX5GMeh4Tu qGio9X1XYinOSDTUYi4qTgQAPSSTsm4CAAA= X-CMS-MailID: 20171201092028eucas1p1ac6becde5f1140b104809e6e4087059d X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171201071310epcas1p4e06bf3264433a5d7318fbb9d6c594c18 X-RootMTR: 20171201071310epcas1p4e06bf3264433a5d7318fbb9d6c594c18 References: <733779CE-86B9-4178-B38B-7E64390BB4C6@dana.is> On Fri, 1 Dec 2017 01:12:15 -0600 dana wrote: > getopts error messages about illegal options or missing values always ref= erence > the -x variant of the option, even if the +x one was used instead. The in= cluded > patch simply makes it report the correct prefix. >=20 > PS: There are a few other places in the code where it seems that the - pr= efix is > hard-coded into the error message, but i didn't actually check to see if = that > was a problem. This patch in addition to the previous one should cover mo= st > cases people are likely to run into, though, i'd think. >=20 > PPS: I didn't add any tests because there aren't any for getopts =E2=80= =94 let me know > if you'd like me to create some. Thanks, I've committed this. I'd be happy to add some getopts tests if you came up with any. pws