From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6795 invoked by alias); 6 Dec 2017 17:20:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42085 Received: (qmail 10620 invoked by uid 1010); 6 Dec 2017 17:20:09 -0000 X-Qmail-Scanner-Diagnostics: from fw.sigpipe.cz by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(213.192.55.98):SA:0(-1.9/5.0):. Processed in 9.114825 secs); 06 Dec 2017 17:20:09 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: neuhauser@sigpipe.cz X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Date: Wed, 6 Dec 2017 18:10:58 +0100 From: Roman Neuhauser To: Bart Schaefer Cc: zsh-workers@zsh.org Subject: Re: Regression / err_return / arithmetic 5.4.x ? Message-ID: <20171206171058.GA9501@isis.sigpipe.cz> References: <20170915211342.GA6027@tower.spodhuis.org> <170915145553.ZM27831@torch.brasslantern.com> <170915193839.ZM29425@torch.brasslantern.com> <170917175028.ZM5119@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170917175028.ZM5119@torch.brasslantern.com> User-Agent: Mutt/1.7.2 (2016-11-26) # schaefer@brasslantern.com / 2017-09-17 17:50:28 -0700: > On Sep 15, 7:38pm, Bart Schaefer wrote: > } > } I reverted 97d4bdb and the problem disappears. Haven't gotten any > } further than that, yet. > > Looks like just one case where use of the new bitflags was missed: > > diff --git a/Src/loop.c b/Src/loop.c > index 40e3bcb..1013aeb 100644 > --- a/Src/loop.c > +++ b/Src/loop.c > @@ -428,7 +428,7 @@ execwhile(Estate state, UNUSED(int do_exec)) > } else > for (;;) { > state->pc = loop; > - noerrexit = 1; > + noerrexit = NOERREXIT_EXIT | NOERREXIT_RETURN; > > /* In case the test condition is a functional no-op, > * make sure signal handlers recognize ^C to end the loop. */ which zsh release has this fix? and does it cover just arithmetic expansion or does it fix while conditions in general? are there any tests for errreturn? i'm asking because i see this with 5.4.2: $ cat > errreturn.zsh <<\EOF > function > { > while false; do > : > done > echo you should see this > } > echo this should come second > EOF $ zsh -fo noerrreturn errreturn.zsh > you should see this > this should come second $ zsh -fo errreturn errreturn.zsh > this should come second -- roman