From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42092-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18207 invoked by alias); 7 Dec 2017 11:30:02 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42092
Received: (qmail 26956 invoked by uid 1010); 7 Dec 2017 11:30:02 -0000
X-Qmail-Scanner-Diagnostics: from mail-wr0-f170.google.com by f.primenet.com.au (envelope-from <stephane.chazelas@gmail.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.128.170):SA:0(-1.9/5.0):. 
 Processed in 5.694529 secs); 07 Dec 2017 11:30:02 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_NONE,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no
	version=3.4.1
X-Envelope-From: stephane.chazelas@gmail.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=date:from:to:subject:message-id:mail-followup-to:mime-version
         :content-disposition:user-agent;
        bh=AhlKn277HsEAcc1J6SoVUn8422+6ErNvOpagv3c2OjM=;
        b=mmci4joMIh1L0dvpcnI4nja9OFkWZpNbQI5i2lYbBbwoGy/deTeycdMSjvrdpfEEjJ
         fHhKHuX6ffySevUi9Bf/D9RGxEZSQD52Bgow+ujK8+7rtP2thR9hYznS8OVs5C9DAiUt
         S0bCEPPWnSXsWrxx8K94wUukbIYfH2o/9VB6j13zpOuJoQcqFs1X740W/0h72Ba4Pk9e
         wz1L5zkGpGWXyOeNUb8CS6t+9O1kyyIBOM97WxgWcYGexBevezTnqCkcFuj8z517ohxc
         v67bYa3sqUMY7cIjXFTpmpeCBQPMvsuh4eXzVzDK2+jR0vJ+PDfCPCwR9BHYcsCJ0n2E
         TeXQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to
         :mime-version:content-disposition:user-agent;
        bh=AhlKn277HsEAcc1J6SoVUn8422+6ErNvOpagv3c2OjM=;
        b=hX5kmTox0cE48/0JzbayQ91viF85aoEna5WKSSlum+Q7mep6uk/Ie7lpVuubjKHVWY
         /aQgrjv93K/2m602YlHB0xfEskHNn+Hj/d7OSxaGaaDseHLnRgRhIg/BWUjochPyXqPZ
         CtWfQmug4GJ55scni7AOwDaH2ezr+tuIueie6bvDMHcl9KU+WeEIhX+BVi6fnXBDNVaA
         i2vdn7+pP41vipphi73Uv/YtuTpkwiEZLc6uM5/o64M72lenSzyMPGDeYhn6FlVXlHK0
         OXJfZBU2pCDjWNYqKdwIz5sSrI9bXjazan6EcnEm+FFaJB7quZyWmT2QtJevXxvOKaBy
         rTGg==
X-Gm-Message-State: AKGB3mK55St5QgVbEHSVOQLPrPXwMfP3dggLAbYMcTCa5XbGZGj9MmPI
	OBtgcVgXyRQztqL2UyxUsRtjtw==
X-Google-Smtp-Source: AGs4zMZKsRJIUeyACESqGomENfO7LPe0W/+9xZVG4h+Kx+xKcrMsfGCEekKqqQ4AF1M3Fnkv0489Yw==
X-Received: by 10.223.189.135 with SMTP id l7mr2113102wrh.231.1512646192587;
        Thu, 07 Dec 2017 03:29:52 -0800 (PST)
Date: Thu, 7 Dec 2017 11:29:50 +0000
From: Stephane Chazelas <stephane.chazelas@gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: $userdirs empty in non-interactive shells
Message-ID: <20171207112950.GA8258@chaz.gmail.com>
Mail-Followup-To: Zsh hackers list <zsh-workers@zsh.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)

Hi,

$userdirs seems to only work in interactive shells. That seems
to be due to:

> mod_export void
> adduserdir(char *s, char *t, int flags, int always)
> {
>     Nameddir nd;
>     char *eptr;
>
>     /* We don't maintain a hash table in non-interactive shells. */
>     if (!interact)
>         return;

Why? It seems to me it would make as much sense to hash it in
non-interactive shells. It may be useful to be able to flush
that cache though.

Note that upon expanding $userdirs in non-interactive shells,
the code still loops over the pw entries.

So, if we don't want to change the behaviour, we may still want
to disable $userdirs altogether in non-interactive shells (and
update the documentation).

-- 
Stephane