From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42158-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 12202 invoked by alias); 22 Dec 2017 20:12:54 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42158
Received: (qmail 10635 invoked by uid 1010); 22 Dec 2017 20:12:53 -0000
X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-6.server.virginmedia.net by f.primenet.com.au (envelope-from <p.w.stephenson@ntlworld.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(80.0.253.70):SA:0(-1.9/5.0):. 
 Processed in 10.067951 secs); 22 Dec 2017 20:12:53 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: p.w.stephenson@ntlworld.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
X-Originating-IP: [86.21.219.59]
X-Authenticated-User: p.w.stephenson@ntlworld.com
X-Spam: 0
X-Authority: v=2.1 cv=I9KYP4Ug c=1 sm=1 tr=0 a=utowdAHh8RITBM/6U1BPxA==:117
 a=utowdAHh8RITBM/6U1BPxA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10
 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=x7bEGLp0ZPQA:10
 a=pefg_WBr5yK6kf7zMEgA:9 a=CjuIK1q_8ugA:10
Date: Fri, 22 Dec 2017 20:05:36 +0000
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: dana <dana@dana.is>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add ability to ignore running jobs when check_jobs is
 set
Message-ID: <20171222200536.14e92995@ntlworld.com>
In-Reply-To: <491C71DF-5618-41F7-9823-A3AE769A3C62@dana.is>
References: <491C71DF-5618-41F7-9823-A3AE769A3C62@dana.is>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com;
	s=meg.feb2017; t=1513973138;
	bh=6qsIoUSQklDLWQxL8SUijH6cumpO1K9wpBhky+Hp6qI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=yh/FGkNC2rgICq9V0xM4dbgmYDv4/swVjM24bWd1ypmozAUMsdg+0jKhS6UCaD6hL
	 uy15zqrSq6oSvyG2F7rViG1IwbQXxj5DIN7P7OSWd/Q6hhBYj2kvFltHmviKdHNh2n
	 +WT6ZAx9PaEMrRnk+NZLbB3x3PGTppSNv7weRdqPjNOViWWo5+nCKuaBXmh62rY2Ni
	 TI9p2xXgx8OIkfnUg01OZHzlISVeRc+MBt7wPg2dY3eyLOdyBj0E/XEnZZosoV5liN
	 Wud+G2qHVpnfhZFZ767r3+mlvVppL31AtYuL6SSNyQaJvi9+LsIvXvjGn3UIgqXw/N
	 lodo681jEvo6w==

On Thu, 21 Dec 2017 22:33:13 -0600
dana <dana@dana.is> wrote:
> The tests seem to work well and are much more comprehensive than what
> was there before (i.e., almost nothing), but they feel a bit strange
> somehow. Let me know if you have any thoughts as to how to make them
> less brittle or more idiomatic.

The tests actually fail with debug on because you get output

utils.c:1836: BUG: Impossible TIOCGWINSZ rows
utils.c:1860: BUG: Impossible TIOCGWINSZ cols

I don't think that output's actually very useful anyway, even in debug
mode --- I've been getting this occasionally for years.  I think I'll
commit this with a change so there's no whine if the number of rows or
columns is zero.

pws