From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 221 invoked by alias); 22 Dec 2017 22:17:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42159 Received: (qmail 27817 invoked by uid 1010); 22 Dec 2017 22:17:25 -0000 X-Qmail-Scanner-Diagnostics: from mail-wr0-f181.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.128.181):SA:0(-1.9/5.0):. Processed in 8.613219 secs); 22 Dec 2017 22:17:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: stephane.chazelas@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:mime-version :content-disposition:user-agent; bh=Wv2CPnUCOEsHBsWXgMw/je3pSEXlTMfq9yMEkw7CpTY=; b=au2tsGRlHxCQ1EbeH/2IqvE5iw5Y3OLZ6fS6J1JxZmioZ+Y5TIbzbxyaGINTxvKPoJ y9sIBMpkf071ufsYiex3iAW/218XDvchcuP5Ig7Y0RBdcrDdmd7/HkKQBNhvuLjFySu/ VzRd3YKqXVJGEtzyncF9YY47d2qXaYTahTXVHp/lAiIdvFVVE9/DVkKsyTaxTwq3XcPR OTwGdmLNXTBnV5mTgua4T1t2xh7dDmAG9lWqrJZJ+ylZodI55MfDdkAOiyfj0P7WV9jI t2K4aAdpbwGPn/Q7omK4Ibj/CSy1bl4o7NHVQxG1668OIxHDNSz9riSXOOsE2axcbGuM oYog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :mime-version:content-disposition:user-agent; bh=Wv2CPnUCOEsHBsWXgMw/je3pSEXlTMfq9yMEkw7CpTY=; b=cO0A4QYQcAVgUtyLG6TraNS2E2ZoD/ze7sX7AD/hViz/6ivVj/yEf1/iRH808aktDJ 6VFqNZdDBtA9TuFiWtN44I4trIxmh4Sn2KEOWXfwKcx8jTUBPkUP0ANpc6RnCg1Qa5Xi m+01QhZ38xuvTxHUklVuWUBNl2UqIogeXlsDIv5zF5rdbjQ4h5WV8K4GPT1IZTv5Q9bN qzXN5PAy00zfI2evZIdnTk2FlvVleixLbLtlMnrgIpQmQVFNHGmNjqZmDQ3DMVot1/3n tIC8foyoEWegjxSbkWsIh1Oh6f4q/bVCJDEZcHA/ONNegMY8TL7eef32WQ3EeGVlaIdz NitA== X-Gm-Message-State: AKGB3mLJiHhUNYBeOKxOFHZzcWIoFnkd72QY/vYlkuR5tnvCeRshUtAw 9h/ebXiFcMiVpC/3KQ9m90WG2g== X-Google-Smtp-Source: ACJfBosnTwb1cj8ew/A/B/TrnBRqOPBGD0oe+mlzi/8YeOumSWbJ0NTCa125GDOgAc3ETmAaBkb4Pw== X-Received: by 10.223.186.9 with SMTP id o9mr15933141wrg.221.1513981032127; Fri, 22 Dec 2017 14:17:12 -0800 (PST) Date: Fri, 22 Dec 2017 22:17:09 +0000 From: Stephane Chazelas To: Zsh hackers list Subject: segv on typeset -A; a=(x y) builtin Message-ID: <20171222221709.GA19562@chaz.gmail.com> Mail-Followup-To: Zsh hackers list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) $ typeset -A a=(1 2); a=(x y) eval typeset -p a typeset -A a a=( x y ) fine. But $ unset a $ typeset -A a; a=(x y) eval typeset -p a zsh: segmentation fault zsh same with typeset -A a; a=(); a=(x y) eval typeset -p a same with other builtins or functions. This: diff --git a/Src/params.c b/Src/params.c index 31ff044..de7730a 100644 --- a/Src/params.c +++ b/Src/params.c @@ -549,10 +549,13 @@ scancopyparams(HashNode hn, UNUSED(int flags)) HashTable copyparamtable(HashTable ht, char *name) { - HashTable nht = newparamtable(ht->hsize, name); - outtable = nht; - scanhashtable(ht, 0, 0, 0, scancopyparams, 0); - outtable = NULL; + HashTable nht = 0; + if (ht) { + nht = newparamtable(ht->hsize, name); + outtable = nht; + scanhashtable(ht, 0, 0, 0, scancopyparams, 0); + outtable = NULL; + } return nht; } seens to fix it (as "ht" happens to be 0 here for empty hashes which explains the segv) but I can't really tell if it's the right/best fix. -- Stephane