zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Baptiste Daroussin <baptiste.daroussin@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.8 available (preliminary announcement)
Date: Tue, 02 Jun 2015 12:06:20 +0200	[thread overview]
Message-ID: <20175.1433239580@thecus.kiddle.eu> (raw)
In-Reply-To: <CAPKC6oJ0fOEeg1--qpufEYQoxTeUnD8KDNSHV5Sfn7J4EtPYCw@mail.gmail.com>

Baptiste Daroussin wrote:
> On FreeBSD I have 5 tests failing (actually for a couple of release of
> zsh) all related to zpty.
> 
> This time I found time to analyse the code.
> 
> It appears that freebsd has posix_openpt, but the code using that only
> used if USE_DEV_PTMX is defined (which is not on FreeBSD)

USE_DEV_PTMX should get defined on FreeBSD. That define is just wrapping
up several tests. The branch guarded by USE_DEV_PTMX also requires other
functions like grantpt() so tests for those should continue to be
honoured even when we have posix_openpt().

With earlier versions of zsh and recent FreeBSD, it was necessary to use
"kldload pty" for zpty to work. That brings /dev/ptmx into existance. It
seems the configure tests are effectively still requiring that. I think
the approach in the following patch should work but I now need to find a
FreeBSD machine with the pty module unloaded to test it.

Is the -o option to test safe to use in configure? It seems existing
tests use || and && but the precedence of those wouldn't be right.

Oliver

diff --git a/configure.ac b/configure.ac
index 6a99aec..d7db8ba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2526,7 +2526,7 @@ dnl these is by defining _GNU_SOURCE.
 dnl -------
 AH_TEMPLATE([USE_DEV_PTMX],
 [Define to 1 if all the kit for using /dev/ptmx for ptys is available.])
-if test x$ac_cv_have_dev_ptmx = xyes && \
+if test x$ac_cv_have_dev_ptmx = xyes -o x$ac_cv_func_posix_openpt = xyes && \
    test x$ac_cv_func_grantpt = xyes && \
    test x$ac_cv_func_unlockpt = xyes && \
    test x$ac_cv_func_ptsname = xyes; then


  parent reply	other threads:[~2015-06-02 10:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31 18:23 Peter Stephenson
2015-05-31 23:19 ` Martijn Dekker
2015-06-01  0:17 ` Bart Schaefer
2015-06-01 22:13   ` Baptiste Daroussin
2015-06-02  5:47     ` Baptiste Daroussin
2015-06-02 10:06     ` Oliver Kiddle [this message]
2015-06-02 10:22       ` Peter Stephenson
2015-06-02 10:26       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20175.1433239580@thecus.kiddle.eu \
    --to=okiddle@yahoo.co.uk \
    --cc=baptiste.daroussin@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).