From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9874 invoked by alias); 2 Jun 2015 10:12:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35360 Received: (qmail 16512 invoked from network); 2 Jun 2015 10:12:05 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1433239581; bh=FV1cLW3QReABrRsQCGMUH10rANyzE9vYdhdQOwTMtTY=; h=cc:In-reply-to:From:References:To:Subject:Date:From:Subject; b=HFV9NYnulBv74DwY3v9+zQXcm1/FsH6seZBUwnDMf5KLZNdFWsBPm7OyrPKgfIXGB4OOfoxMss3nqatOGSwdn8l16u2UcRXmOS4hpWOr8INU4hm1EMmQIjlaNvQ99ZQajqCR72jujlmi5004VKZoUTzliZ2z+aHQmVKGdZRL/WPMJi9qghJmORl6twmT3uNRuH9WX/ZzEmim/Q0sA/xkewPVcLdv5q61XfjB+TngGMh2QkA+CGc30X0zMr+w1yWCId6Wc0Ze6do0fUzFWEUgeaceSSY4npor+t77DSnjVwU5zxGMgsoYVGDFwKE7TI0A4/7dfezzU+13LTE4QAjyAw== X-Yahoo-Newman-Id: 650033.44265.bm@smtp115.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: rGUpgGMVM1mT89B1guj6lAFjDfV0JpTW0AZyblmqapUfUvu mzANyws9SkWeVD_k8YgHKg8HAEmWB.MvDIBkoG34LKSkeLKsx66HTbM1SZrA zam7PNb7nxOwo2N43z935XfFs02twi0CqBuJdfidA9KbtHJIIIn1WGtu7tnA 7U1eLTbjgdylkZJIfVFm8_7Lj44QmfdRsQOgngqFnTo9hJwpAOWDuKae6cdw vbeVf..5JVg93IN2VonC3r_gWzII_rU6HeHYdq_fJD2R1fx2INGUkw94xPIQ q1Up8odBCqajBW78.aqrgfjYosONjYxkR77Q31sbLWtzNdnh5Lbnl2r3tG2h LAszv3.he1lxawndu5pcRFC.8jzZjLFM6MQH4YbVOp8pujBNxLoaJdvJGF45 kHRvKTYUULSFlpZPjk..9dI2omUxT.2NBkuwQKVuxho_99ZRRYnXOx05YJpc 35PwYAQpWzPbW5quJc0_iDbr5JCi6QZIZB45dp275Jhl8xBOjOs6ESvq3CYF ev9bcUmZ.5hvuJH8rCuamYhode0BsXUZw X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- cc: Zsh hackers list In-reply-to: From: Oliver Kiddle References: <20150531192334.26a88ef9@ntlworld.com> <150531171724.ZM29828@torch.brasslantern.com> To: Baptiste Daroussin Subject: Re: zsh 5.0.8 available (preliminary announcement) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20174.1433239580.1@thecus.kiddle.eu> Date: Tue, 02 Jun 2015 12:06:20 +0200 Message-ID: <20175.1433239580@thecus.kiddle.eu> Baptiste Daroussin wrote: > On FreeBSD I have 5 tests failing (actually for a couple of release of > zsh) all related to zpty. > > This time I found time to analyse the code. > > It appears that freebsd has posix_openpt, but the code using that only > used if USE_DEV_PTMX is defined (which is not on FreeBSD) USE_DEV_PTMX should get defined on FreeBSD. That define is just wrapping up several tests. The branch guarded by USE_DEV_PTMX also requires other functions like grantpt() so tests for those should continue to be honoured even when we have posix_openpt(). With earlier versions of zsh and recent FreeBSD, it was necessary to use "kldload pty" for zpty to work. That brings /dev/ptmx into existance. It seems the configure tests are effectively still requiring that. I think the approach in the following patch should work but I now need to find a FreeBSD machine with the pty module unloaded to test it. Is the -o option to test safe to use in configure? It seems existing tests use || and && but the precedence of those wouldn't be right. Oliver diff --git a/configure.ac b/configure.ac index 6a99aec..d7db8ba 100644 --- a/configure.ac +++ b/configure.ac @@ -2526,7 +2526,7 @@ dnl these is by defining _GNU_SOURCE. dnl ------- AH_TEMPLATE([USE_DEV_PTMX], [Define to 1 if all the kit for using /dev/ptmx for ptys is available.]) -if test x$ac_cv_have_dev_ptmx = xyes && \ +if test x$ac_cv_have_dev_ptmx = xyes -o x$ac_cv_func_posix_openpt = xyes && \ test x$ac_cv_func_grantpt = xyes && \ test x$ac_cv_func_unlockpt = xyes && \ test x$ac_cv_func_ptsname = xyes; then