From: Daniel Hahler <genml+zsh-workers@thequod.de>
To: zsh-workers@zsh.org
Subject: [PATCH] [RFC] Reset pipestatus in zleread
Date: Thu, 11 Jan 2018 16:22:11 +0100 [thread overview]
Message-ID: <20180111152211.18116-1-genml+zsh-workers@thequod.de> (raw)
From: Daniel Hahler <git@thequod.de>
What do you think about this?
I am looking at $pipestatus in my prompt precmd function, so that with
"false | true" I would still get an indicator that (something in) the
command failed (since $? (status) is 0 in this case).
However, with e.g. "foo=bar" (executed via execsimple) $pipestatus gets
not reset.
This patch resets it in zleread always.
---
Src/Zle/zle_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c
index be2b062b0..522cf7a1a 100644
--- a/Src/Zle/zle_main.c
+++ b/Src/Zle/zle_main.c
@@ -1196,6 +1196,12 @@ zleread(char **lp, char **rp, int flags, int context, char *init, char *finish)
int old_errno = errno;
int tmout = getiparam("TMOUT");
+ /* Reset pipestatus.
+ * This is useful to have status and pipestatus in line in precmd
+ * functions.
+ */
+ numpipestats = 0;
+
#if defined(HAVE_POLL) || defined(HAVE_SELECT)
/* may not be set, but that's OK since getiparam() returns 0 == off */
baud = getiparam("BAUD");
--
2.15.1
next reply other threads:[~2018-01-11 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 15:22 Daniel Hahler [this message]
2018-01-11 17:16 ` Eric Cook
2018-01-12 18:44 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111152211.18116-1-genml+zsh-workers@thequod.de \
--to=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).