From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18810 invoked by alias); 21 Jan 2018 20:28:43 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42312 Received: (qmail 11759 invoked by uid 1010); 21 Jan 2018 20:28:43 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f182.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.182):SA:0(1.6/5.0):. Processed in 1.479122 secs); 21 Jan 2018 20:28:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sqaaK6FVGhzbZKWM8UmJjUTQug4lGdbqEuMSQfSOdXk=; b=AGRWGb5qDBQMZkzGKys38YVCMFU3/Ag6TiXLixz5QRRmfH9zP7vQ0KdJgsaOUpiQc0 Bxd7zOFYp2/R3PukqZaojbm+jH1T7eIutg9hTqb+FgLsIWOdCDTfSBaB4cOHpsBflwOh FmXDjUF0hUeVUzQpDW4RMvS9IxkVQIM7m1bKUsRZbvp+lhEIK7xFY2J8TWB6CNUKI0Ob nhtZJ5pG2sb1ctJ4vjjeF0mTqgWL4HPvGtj6ysmMiRfly8a22Qg6Y/2+M9q+difniPzq Kry5tv1muU7eICC+JMDTgBdpCt7wOv3bL5Uu7xgI3FYi8kfACsRM9ZAopir+z6raWvGP Okfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sqaaK6FVGhzbZKWM8UmJjUTQug4lGdbqEuMSQfSOdXk=; b=ZfIkqtmb8St/5yR5Va4aip7p6qA9SsbKmtOpt8nqR5H8o2+nyWesNYJFJpsUplyhZs kOau3z/BMXqminULdu5/wc1+/pHaA2bTuCEoYP8tFumoBXoiW6WC2WyBnYvwfsA4nTdh MAo9luMjiF4qbXInorR/6XsAx98OsHwO3ebvPUg9VN8ho02yf+NIUpRPVxiNBjBlIwQp /ZNDmUEocNkh40/a9byS59SInynUMyY8bKCX3lVRwHYY0YzThpuJf3lmyBcU5+ZNoxxR bIDLRPrP9s67gChF3HpYnJ2BhwkjyLc2rroasGiP8lP0XBDY+pteBJ8FO2oRvmgxdnT8 hi2Q== X-Gm-Message-State: AKwxytfWY+YELUAswzrnu6tgpC/cvKIBttbPFYusEHSW6SUaDGvAOjrx W98EwocVDNSE9NICovEa1PcO/Q== X-Google-Smtp-Source: AH8x225BK2B8ASpf1JgP2c5uDXvYgr+czVhclYvtCUr6dMVfAPbz9An8ZRIeJnt/XkDDi8tyI+oZhA== X-Received: by 2002:a17:902:7887:: with SMTP id q7-v6mr2266438pll.86.1516566519565; Sun, 21 Jan 2018 12:28:39 -0800 (PST) Date: Sun, 21 Jan 2018 10:28:36 -1000 From: Joey Pabalinas To: Bart Schaefer Cc: zsh-workers@zsh.org Subject: Re: [PATCH] jp: fix segfaults during parameter expansion Message-ID: <20180121202836.77alwuapsgbwzsbr@gmail.com> References: <20180114060557.hmrvpg6t4rdebgv6@gmail.com> <180120160304.ZM12968@torch.brasslantern.com> <20180121014758.lu7vt7qg4kuup5qd@gmail.com> <180121094326.ZM11602@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ynm36lm4gxww3wam" Content-Disposition: inline In-Reply-To: <180121094326.ZM11602@torch.brasslantern.com> User-Agent: NeoMutt/20171215 --ynm36lm4gxww3wam Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 21, 2018 at 09:43:26AM -0800, Bart Schaefer wrote: >=20 > There's no reason to do both of these changes. You do the first one if > you like the "reference used with array" error message, or you do the > second one if you like the "not an identifier" message. The second > one will never take the dupstring() branch if you have done the first. Noted, I feel like the "not an identifier message", although strange, is more useful here. That one at least sort of makes sense; the other "reference used with array" message took a few minutes digging through the source to even figure out what that even meant in normal context. When i send updated patches, what's the best format? A new email after a separate response mail, or as a single email with the response at the bottom (or some other third option, maybe)? Sending this one as its own separate mail for now. --=20 Joey Pabalinas --ynm36lm4gxww3wam Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKlZXrihdNOcUPZTNruvLfWhyVBkFAlpk9/QACgkQruvLfWhy VBkJhA/9EVpRYeAFaG8VW06iz23wLu0rM2ab6LimpXU0HguWKoPqhoVMY3QRAk+h W6xUdi3K6VY/bUcMaAAGYHhIBWGK7VAF6N+E9wCqWUhl171yZfbExLNNeIy6nDzH qLKgweTYCm6ZE1Bb6JSuUnM7c3aKHeTMRz6oWJJ3NLdcnP2rw1xtPGQepj4V5OoL P8ZiV7Z+2L3ewTR4S4QaS6goxeNlFTRCQyHnZJlQAeD2XQW9x32XD3Be8q7oYpkf uvC0vkk/em8YKQNeDvRm530HTRnGHiPmeAOkrjOySNY9u0sVZf09loyrhNC14kfI HAqzkwraMOxgjAmCB3g/zuIEDm1s5O6IGP7NN45y7IAbpuJG5AqIBU1qUD21uyLy rbkS26yU1yCk5Y4X6ce9lRUCBDLE42nf3K9z4q7vVX+V477tt76B3vOkRlF8fdD/ N5eU3fH/gy/fWZ86PblhILQNenn6SKsZfyid7z03znEd6pTOiY0J/AfXsy4clkFu 9jcl3C6pVzzTf75CtYcoZIomsax+biCGQcv0UlrCgeF8rX4PM58LOYaFmguvlfRu csPchHR+ZfIYfdS1uZuZvS8axRoHDXJQyrZIdh2LkdmhFPOkq/eNIQH1K7RAm4Bc +JTV930pI1/excVA1GIRsk9+YGY6m02tJTBFHgG/qZRQp++EC4s= =9XQb -----END PGP SIGNATURE----- --ynm36lm4gxww3wam--