From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10732 invoked by alias); 21 Jan 2018 20:29:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42313 Received: (qmail 4786 invoked by uid 1010); 21 Jan 2018 20:29:46 -0000 X-Qmail-Scanner-Diagnostics: from mail-pg0-f66.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.83.66):SA:0(1.6/5.0):. Processed in 1.709165 secs); 21 Jan 2018 20:29:46 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MPinswWJ++M7IRTZPpwtdPCdO/QNEes7QCKkksPS9aA=; b=hpRrpnmv67W2X9taupa/D6rZU5oQnV0vHvqP7Hb0NULwqyQCx5aD3iFjci9C5nJ4HQ tbC2x7Ff7quV9HP3T2qCcqsWzEDXmKe+qtskxDASrJFDvyQt2QJZE38Lb15ppsjyG8ej rZMWDHhPkq9kA88wD9zfW8kB5xsGkdvcSJ/MRchio02TaL01vk927Kwy95Yh8aUs6RWT YcQ/JtL6NMVXnI+mYPdFUlOZrxfNyHbPjH7S8PIeK034YHK+LV7vltFoxvzwAmmJPLqr 4Qjx1GzAahHteEbWUeP1WX8RplrEwTrsorUq5pqAqMtfD6K17iq0GAcFgmo5lJiEuMJA sa1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MPinswWJ++M7IRTZPpwtdPCdO/QNEes7QCKkksPS9aA=; b=fX9JPzVl6D8ULhxgi7I+a4iw7U0RnrhPOFEuHzsnZ8cK2MtXwDArxEEWU8VxlkLDDD Xa7/PFYs1FvSUlJ32nkvqEwcHdthoWCJvhFwywScgRxlpHn2o9wl4fYJ0CSxjtLYa19m MQXXR974zIOxkWP5McxyY2bCj90IVjll7h3uEJC6lJJgKeooeWzJl6gawwVBnHDrTzaR jE5IWA6KZ0Y9N3gPyvsFNFIql0ZmydQCBvSsOdQB2TjqGJlzfLFOy2gtHS5udCaRxUKI BgALJAeBrM53NlizsOz6+lRnAtfWf8kmX8O7zJLnKeYD+1KECEzuSoHCaBt7ssiZFVxT L3fA== X-Gm-Message-State: AKwxytfdQaY1jEkv0kOJGqc0u1/yEXIpIkGgtDeZFXLNJyAZneW3s6Ob Ig2onXVFY6Ux1+SWioxQhAo= X-Google-Smtp-Source: AH8x226/1+h5sU7fXc8eXj3T1rqQf29yiPlC7seBteSOKPJWzTbghNt5Q8hdTWkc7v12+ZnIbPtiQw== X-Received: by 10.98.207.6 with SMTP id b6mr6242496pfg.187.1516566582664; Sun, 21 Jan 2018 12:29:42 -0800 (PST) Date: Sun, 21 Jan 2018 10:29:40 -1000 From: Joey Pabalinas To: Bart Schaefer Cc: zsh-workers@zsh.org Subject: Re: [PATCH] jp: fix segfaults during parameter expansion Message-ID: <20180121202940.rzrq6ymofbyxkp73@gmail.com> References: <20180114060557.hmrvpg6t4rdebgv6@gmail.com> <180120160304.ZM12968@torch.brasslantern.com> <20180121014758.lu7vt7qg4kuup5qd@gmail.com> <180121094326.ZM11602@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lozapcjlsd4uefq2" Content-Disposition: inline In-Reply-To: <180121094326.ZM11602@torch.brasslantern.com> User-Agent: NeoMutt/20171215 --lozapcjlsd4uefq2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Running: > $ zsh -fc ': ${${(PAA)p[foo]}::=3Dx}'` in current zsh versions causes: > > [1] 4441 segmentation fault (core dumped) zsh -fc ': ${${(PAA)p[foo]}::= =3Dx}' Also happens when testing with machabot: > 19:42 > : ${${(PAA)p[foo]}::=3Dx} > 19:42 jp: zsh[248]: segfault at 0 ip b7dfcda3 sp bfeb9ebc > error 4 in libc-2.13.so[b7d84000+149000] Add a simple `dupstring(s)` fallback. Signed-off-by: Joey Pabalinas Requested-by: Bart Schaefer 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Src/subst.c b/Src/subst.c index d027e3d83cadc631a7..a265a187e8730868a9 100644 --- a/Src/subst.c +++ b/Src/subst.c @@ -2430,7 +2430,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt= , int pf_flags, val =3D aval[0]; isarr =3D 0; } - s =3D dyncat(val, s); + s =3D val ? dyncat(val, s) : dupstring(s); /* Now behave po-faced as if it was always like that... */ subexp =3D 0; /* --=20 2.16.0 --lozapcjlsd4uefq2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKlZXrihdNOcUPZTNruvLfWhyVBkFAlpk+DQACgkQruvLfWhy VBkEAQ//Qm878EM4/rsZCWeZWXAs+CD21cNpFmVCta0Xmguc9cSrhdUOZlHP3egM UFeBYFooaq9pIS/p5f3EslR8G5dv1Hk1PvE7DZ3HGKTDVw15Bz+0PRZOLc32PrjS TiCNimfd1y59Ztoa6ouqgdODYT+EnJVmt1dBqnDKprNZ3vRy9ZYadr7gmOUguOFk mb+f3gb3ixm4go+RVmbG45F+c9rVaV69Y3pqoDGf1xjjBDGFLc+6ACN7qn/XvfVD EEvVY8ooqbVq0nqFYtgu3gkwgWqZmGd6xaLRn53OeIxg07sjYjJA2nu2TRdeoNYB uI76x7HjjJdDWWCGCha7bZBlQVZ2MWj4rXEDg9MshJRfB5eQz1nlEqw/FTYI5+83 z28SPWWnYEnEKDLMYfFEiGpW/Arl2J5rMTMOT7omePfkIeTCTCMxdaRVWXbts31E +8/uYoArgO3Mcptr9Ej0xZwRJdQ481j94mulYUOiNkHJWJJjzTyB8Qkdsyp0pGkp 57TgDb2PNcchNzB7PitBAQJ9ucBDrZ1mM+Vzicz8AsAaFattdj38s2JtqzuKL7/c JjYsqn/tqLna0pT6x65C/pfio5Q1ClDa4HPngX4btEQYGD4Yxcr5FlO1i9Jdy50+ kF6gUr+2fHjoXO6tVeseIc9VBzNy3qB01zvMf147VEpURA50uUc= =3Vs+ -----END PGP SIGNATURE----- --lozapcjlsd4uefq2--