From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8091 invoked by alias); 1 Mar 2018 09:21:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42413 Received: (qmail 1371 invoked by uid 1010); 1 Mar 2018 09:21:59 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-6.9/5.0):. Processed in 1.69027 secs); 01 Mar 2018 09:21:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180301091515euoutp01eb61dcf1122b83e09f7960f5022cf439~XwRmqZfiv0575405754euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1519895715; bh=jA8Lg5QOe2+QEZkrfp3ifAc8bXhV6MZhQ8s8DS0JW8E=; h=Date:From:To:Subject:In-reply-to:References:From; b=RXes5rMR0M9iP3maBU8aJlD5VeMsrbJSL9bpkcBMgsffzTIvjfJd7ez1UhgkgFaHT stqxZ1pTu9ILMQdHY7PLe0Hw5iyza8G4Rx3V7DGUO7uI0Kk1d9hTK0sESVYaP3JjC2 KGgWIR9AwFaWSCcGEmxYoeUJXYW+hfuZ7N4Wdl2E= X-AuditID: cbfec7f5-b45ff700000028a9-73-5a97c4a2222f Date: Thu, 01 Mar 2018 09:15:11 +0000 From: Peter Stephenson To: "zsh-workers@zsh.org" Subject: Re: [PATCH] remove unnecessary checks for NULL in zfree and zsfree Message-id: <20180301091511.40f12304@pwslap01u.europe.root.pri> In-reply-to: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsWy7djPc7qLjkyPMjhyRNHiYPNDJgdGj1UH PzAFMEZx2aSk5mSWpRbp2yVwZTx49oOlYCpLxZRV05gaGDcwdzFyckgImEj8+DqNqYuRi0NI YAWjxPpJG5khnF4miV3Hd8BVnVgylwUisYxR4uaZPewQzjQmifNnb0H1n2aU6Jx4FKr/DKPE 9R8NYP0sAqoSTQ872UFsNgFDiambZjOC2CIC+hIX/9wCs4UFvCUunWhhA7F5Bewlmo83soDY nALxEnPn/AGr4Qeqv/r3ExPETfYSM6+cYYSoF5T4MfkeWD2zgI7Etm2P2SFseYnNa96CHSQh MIVNYtnFrVDNLhLHppyFsoUlXh3fwg5hy0hcntzNAmH3M0o86faFaJ7BKHH6zA42iIS1RN/t i4wQG/gkJm2bDrSBAyjOK9HRJgRR4iFxpKMdGniOEnP6l7GC2EICzUwSfzdqTmCUn4Xk7llI 7p6F5O4FjMyrGMVTS4tz01OLjfNSy/WKE3OLS/PS9ZLzczcxAmP/9L/jX3cw7vuTdIhRgINR iYf3ROP0KCHWxLLiytxDjBIczEoivKe3T4sS4k1JrKxKLcqPLyrNSS0+xCjNwaIkzhunURcl JJCeWJKanZpakFoEk2Xi4JRqYHToYl1aGRl7J/TOurfTrixdNGvPv6LbHBIsP3c5ll8sagxZ U7z75vrN/E+VfiV+KTtxJFNK367q0+uE5MJ8S681CSITXse4b+qesNaP4bFKSHNIC8e+rraM xxbcJq+Xbf36Kb4zbl0dV9v/oCPHUyYt/iP77u+h8A8xS+OL8474XItx2vfuUoASS3FGoqEW c1FxIgAtX0Ax+QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xa7oLj0yPMpj4xdziYPNDJgdGj1UH PzAFMEZx2aSk5mSWpRbp2yVwZTx49oOlYCpLxZRV05gaGDcwdzFyckgImEicWDKXpYuRi0NI YAmjxK1rU5ggnBlMEu8a7rCAVAkJnGaU+L1HCCJxhlFiUtsWsASLgKpE08NOdhCbTcBQYuqm 2YwgtoiAvsTFP7fAbGEBb4lLJ1rYQGxeAXuJ5uONYL2cAvESpw/OZ4YY2sokcX3PAiaQBD9Q 89W/n5gg7rOXmHnlDCNEs6DEj8n3wJqZBbQkNm9rYoWw5SU2r3nLDHGpusSNu7vZJzAKzULS MgtJyywkLQsYmVcxiqSWFuem5xYb6RUn5haX5qXrJefnbmIEhu22Yz+37GDsehd8iFGAg1GJ h9dh/7QoIdbEsuLK3EOMEhzMSiK8p7cDhXhTEiurUovy44tKc1KLDzFKc7AoifOeN6iMEhJI TyxJzU5NLUgtgskycXBKNTCWvXOcL3g2mPVF1a/OY79N2tYyR7pu7zijKbs3cNpBmc8VW+NO HJm2x2qb85TXjzv/JEziKLl46pSo2PygI7FBUVsYDn9v5HpdxS+ak9RWu/fN8y3PXBmW66ap JZqZSJ8N+2bHXZ56ZDePee20hUdXmLcZfX+zvGfDeTabTU9225xf5n8mNMRYiaU4I9FQi7mo OBEAdzp0hlcCAAA= X-CMS-MailID: 20180301091513eucas1p25de1d253246d99baa39d5729cc992d73 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180301011811epcas3p10cf21954585a10800bb3f22b9d986573 X-RootMTR: 20180301011811epcas3p10cf21954585a10800bb3f22b9d986573 References: On Thu, 1 Mar 2018 01:17:12 +0000 Taylor West wrote: > According to section 7.22.3.3 paragraph 2 of the final committee draft > of the C11 standard, if free() is passed a NULL pointer then "no > action occurs". The current checks on `p' in zfree and zsfree are > unnecessary---this patch removes them. We haven't even progressed to C99 yet... zsh is designed to be defensive about some pretty old stuff. Unfortunately, it's quite difficult to know when where it's still being compiled. pws