From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5124 invoked by alias); 1 Mar 2018 21:37:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42416 Received: (qmail 27303 invoked by uid 1010); 1 Mar 2018 21:37:38 -0000 X-Qmail-Scanner-Diagnostics: from mail-pl0-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.160.41):SA:0(1.3/5.0):. Processed in 1.487212 secs); 01 Mar 2018 21:37:38 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SQTT4Ajesqiukvo2/OOJpZvKyKMhpH/FlR/ZRmhYEeY=; b=Fa2yQa/+CoG/m/qVX8AKjRaftWekeQILvLIoSSX/8tA3yL/ulqUD/L35VSKT3vu5sH JtPjd7Gv3yVde+UsJNTY1sAvoowsJv6kJ8Byd1+jPd08aQcg4WsWaIUvai7rFguEoJxk hrbdaRbPLIZNuPgH7/NsheGtE8tbsPisbstnvC5prz2XKD2nQuDdinE5saDbszxn5B2U 4lSkuJroPPmKHlTnC3+AdHGwq7PfXjZPSv4hdLMGo9WmWmHr75ciBogANVVYHnglM2td s121mAl29APiLdqsmMyfles3GhQOny0JxsO/y1TFGMK1xIWBWx7/8VQ0aT4By1H9Kmxd t5wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SQTT4Ajesqiukvo2/OOJpZvKyKMhpH/FlR/ZRmhYEeY=; b=E6GrijZUf/g+orzxfwOpDca3ahX9gaFqdt7LzuYjwN1DOozKjUTjxNNSGuwYcxm9RG 4H54MzML58Y3BW898DbKuCXl6xfOQ21rVpIgHkKNR+muFX3Wu7/GXsvUKl/5oDIGwPud nvVNNcXxp2QX3n/nYWM3JOJhmtCfi8lnv3oc3l9+UsXuNpDneXc3q3s434pEfqUO131q 2iEbjko152uHnxHRpGhLwSzvtAEEGWauILC2jO4NZzgI/VCcwDRf9fwhpU0uTzYkYAaS m/HVdEnCRtY7T1XWaungwT2huIl/E+iw49M0o6MMsgrkBh+WT8abrv78bvntAFi61Sxn v3tA== X-Gm-Message-State: APf1xPDXTUSmB7lQW8F1zqtOmuwTFYhSKQ/wufUqhGfijzP1po2mTiRh Dl0Ch1+Nz1rHluH3BQR6hXo= X-Google-Smtp-Source: AG47ELvLxwikLO0EbBD2a20JnblQntiZimlD3Rdh3hsFEdvnKjIA9VzQckiMOMV2g8UNRhvTnSYSlw== X-Received: by 2002:a17:902:8349:: with SMTP id z9-v6mr3092330pln.163.1519940252899; Thu, 01 Mar 2018 13:37:32 -0800 (PST) Date: Thu, 1 Mar 2018 11:37:29 -1000 From: Joey Pabalinas To: Peter Stephenson Cc: Taylor West , "zsh-workers@zsh.org" , Joey Pabalinas Subject: Re: [PATCH] remove unnecessary checks for NULL in zfree and zsfree Message-ID: <20180301213729.voxfugclges27liu@gmail.com> References: <20180301091511.40f12304@pwslap01u.europe.root.pri> <20180301194554.12932e8b@ntlworld.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="st64q4ew46w6krvb" Content-Disposition: inline In-Reply-To: <20180301194554.12932e8b@ntlworld.com> User-Agent: NeoMutt/20171215 --st64q4ew46w6krvb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 01, 2018 at 07:45:54PM +0000, Peter Stephenson wrote: > OK, I would be a bit surprised if there were any pre-ANSI compilers > still in use. Unless someone tells me they have a SunOS 4.1.1 system > proudly sitting on their desk. Yeah, I mean even in the C89 draft the free() function is required to be a no-op if the pointer is NULL: > 4.10.3.2 The free function >=20 > The free function causes the space pointed to by ptr to be deallocated, > that is, made available for further allocation. If ptr is a null pointer, > no action occurs. Otherwise, if the argument does not match a pointer > earlier returned by the calloc , malloc , or realloc function, or if > the space has been deallocated by a call to free or realloc , the > behavior is undefined. So I don't see any problems with this patch, personally. The only times I have ever seen people use pre-ANSI compilers they were only uses them on pre-ANSI programs; I don't think anyone expects to be able to compile moderns programs with a compiler that old. --=20 Joey Pabalinas --st64q4ew46w6krvb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKlZXrihdNOcUPZTNruvLfWhyVBkFAlqYcpkACgkQruvLfWhy VBkwVhAA2GYEwmOgzdM3/WOU/uqeuVv2Kbk0iDNs83cwsNrlDAcD9qKFqr/Vc3sI 6C40p+BiRl41VM7i1lwL4MCK6X//byRg/OQ+6l9JOl40Vf26pDKSncRdbzMQe40w 93TSPT5+D6MeoDUEL/AbdQmbqOflWkRY79SsQPIDjOd7hyjyGLgIHx0AJ/pCouxP 3KgyfF9TsN0HdVOGQFXsIiBYa/8Lt86+snPgKdTkDs1E3kify51HUGy58iGt7jtU 7CdqeY1SsU5qRcUfAk34acf4pDfcpW1DmSbie/4QlcbIJQ/KIDPF6oJ5jhN1fkwe uiqBZ2iP9nEOyl9+LPwrDpQqW8Y82FZLKjMbJ7G5WdLPiJ90C6vcb1rWITxiialW zIMiUvjc8LGq8wFTXZLwEILb+2XbbNUqB32HzYSl8fXBgfqamcb93D+r7OAoLQH/ pqUHuTmu9RW1U7suOkEU4mYxo5LuDdHxNs+o1/5B6DJwkSAMNaENaebKWGfUy7or YndhJ6duYuQ35ZRc5X2QlSI5ux2ahnZINt9OmnDk9xAyGRrVAr2kBrtmqH9Kq8Da 29Eq+In25BSkGb/ls/aWwpYjkDIZ34k+ipgeHqcP95r7h3HcKT/k6RYg9HfyQCg8 ItFiFSLlIViCKfhYJLf2Q/OHtWaDD4yn/DB+sOCE4xifDYuuMtY= =yOQj -----END PGP SIGNATURE----- --st64q4ew46w6krvb--