zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] use .zwc files with identical timestamps
Date: Mon, 05 Mar 2018 09:32:31 +0000	[thread overview]
Message-ID: <20180305093231.0be29578@camnpupstephen> (raw)
In-Reply-To: <37c4799b-f7d8-87b3-fca1-48ce3916b779@inlv.org>

On Mon, 5 Mar 2018 01:54:42 +0000
Martijn Dekker <martijn@inlv.org> wrote:
> Op 14-02-18 om 06:11 schreef Martijn Dekker:
> > I have been experimenting with zcompile to speed up loading sourced
> > library scripts. I found that .zwc files are not used if their
> > timestamp is identical to that of the source file. This can occur,
> > for example, if an installer script installs a script file and
> > zcompiles it immediately after. The granularity of file system
> > timestamps, at least on my system, is not sufficient to register a
> > difference.
> > 
> > I think it should be a safe enough assumption that they correspond
> > if the timestamps are identical. The attached patch allows zsh to
> > use .zwc files if their timestamp is greater than, or identical to
> > the source file's timestamp.  
> 
> Any opinions on this?

Looks OK to me; I've committed it.

Thanks
pws


      reply	other threads:[~2018-03-05  9:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  6:11 Martijn Dekker
2018-03-05  1:54 ` Martijn Dekker
2018-03-05  9:32   ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305093231.0be29578@camnpupstephen \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).