From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42463-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8718 invoked by alias); 14 Mar 2018 14:42:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42463
Received: (qmail 8697 invoked by uid 1010); 14 Mar 2018 14:42:56 -0000
X-Qmail-Scanner-Diagnostics: from mail-wr0-f172.google.com by f.primenet.com.au (envelope-from <stephane.chazelas@gmail.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.128.172):SA:0(-1.9/5.0):. 
 Processed in 1.197005 secs); 14 Mar 2018 14:42:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=ham
	autolearn_force=no version=3.4.1
X-Envelope-From: stephane.chazelas@gmail.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=gSSlHtEpMeXEi4kdqf8jubAPPd0igDZpuvHYr+O9vUg=;
        b=rSCvhWUXnuE9HXG6SXZveUNt7BPDCph2OorTn1CoW4En3+iGfAQvlbe8kpHTe8lwmh
         tn518VVBLJQXhNJWmS4f3LAHMoh7h1LIleI54SnzaKmxRZYs6mVDXpD6S1r5Cw0/9FeQ
         WsfAmFIH3IYHaTohdr+yrgy5QvLlkl6O3O3WCvW06G/25rQinEcKrFJqipwMnKfhcbtl
         Cr+u6ZVd92q8MXRnR61cm/eViqek2qbJwTJtFRSq5ZalebrOSVTNk90sTT4xkZz2JEwh
         zFPgdyBCMVr5powaoWqNPgR7yCIOuRyJkuPBie+1IyfgWBsgI6QIJ7siEbfHJFt8i26o
         CzSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id
         :mail-followup-to:references:mime-version:content-disposition
         :in-reply-to:user-agent;
        bh=gSSlHtEpMeXEi4kdqf8jubAPPd0igDZpuvHYr+O9vUg=;
        b=CZuZAV/8TajV3YvXoNFULiLelZnHFwO85GCiiO+mG51hV9sKwOOn89SJsjhZ5z01Ie
         TNfr5oKrB7C8GPjykfWKb7t/uXT5eViWhE2XeS/8gjwNbvOKhXxRoMoh2u54FeDbYeUS
         5hFExufCPPdj07A0m5kMvmzpre27mGdTEQYXSwDRVVNHg7BI6IPIPhLC1czoeQ8CI5Yn
         yqs+Q3WW52x0Fm8pEW9V4339XsS/N74wkQrVFWHh3Tuew9AkblD+Bn1cY+3hKUnvaD+O
         BB34AlC0mzuHviZ7fB4WhyDshTJWDbhGnrpMk7q32BHzhq71hpZJPh4TL3xg6pS7CYKB
         dFWg==
X-Gm-Message-State: AElRT7Fy9btz6hNW+yZ8QlEqaQCzTk3nrrnnGhx5oeOtW7auxUsJnN49
	wMaj45RNNb36Ethka0CzqS4=
X-Google-Smtp-Source: AG47ELv2kfudPwhdJkXkO946X0tBm7T0LwoidjxITjRM2cKMhRMyioo/MOj4pNhv8boIDiPFYXHbLA==
X-Received: by 10.223.156.208 with SMTP id h16mr4259849wre.123.1521038571699;
        Wed, 14 Mar 2018 07:42:51 -0700 (PDT)
Date: Wed, 14 Mar 2018 14:42:48 +0000
From: Stephane Chazelas <stephane.chazelas@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: $(<nofile) doesn't set $? to non-zero
Message-ID: <20180314144248.GC10404@chaz.gmail.com>
Mail-Followup-To: Peter Stephenson <p.stephenson@samsung.com>,
	Zsh hackers list <zsh-workers@zsh.org>
References: <CGME20180314103335epcas4p30222f0df02adda27cbddbe62075ff9ad@epcas4p3.samsung.com>
 <20180314103254.GA10404@chaz.gmail.com>
 <20180314105442.28c5554a@camnpupstephen>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180314105442.28c5554a@camnpupstephen>
User-Agent: Mutt/1.5.24 (2015-08-30)

2018-03-14 10:54:42 +0000, Peter Stephenson:
[...]
> We set lastval = cmdoutval if it's an ordinary command substitution, so it's
> easy to make this consistent with that behaviour.  Doing so seems
> unproblematic.
> 
> pws
> 
> diff --git a/Src/exec.c b/Src/exec.c
> index e5c6455..299b816 100644
> --- a/Src/exec.c
> +++ b/Src/exec.c
> @@ -4514,6 +4514,7 @@ getoutput(char *cmd, int qt)
>  	untokenize(s);
>  	if ((stream = open(unmeta(s), O_RDONLY | O_NOCTTY)) == -1) {
>  	    zwarn("%e: %s", errno, s);
> +	    lastval = cmdoutval = 1;
>  	    return newlinklist();
>  	}
>  	return readoutput(stream, qt);


Thanks. I think that code explains why we don't report an error
upon read errors ($(</), $(</dev/mem)) as we use the same
function that reads the output of normal command substitutions
where read errors are not expected (pipe).

I suppose it's the same in other shells.

Would it be worth doing some:

  	ret = readoutput(stream, qt);
	if (errno) {
	  zwarn("%e: %s", errno, s);
	  lastval = cmdoutval = 1;
	}
	return ret;

there (or something cleaner to avoid relying on errno)?

-- 
Stephane