From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42467-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 23797 invoked by alias); 15 Mar 2018 09:23:14 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42467
Received: (qmail 22841 invoked by uid 1010); 15 Mar 2018 09:23:14 -0000
X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.12):SA:0(-6.9/5.0):. 
 Processed in 1.759761 secs); 15 Mar 2018 09:23:14 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_DKIM_INVALID,
	T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180315092308euoutp02f402b6eb4573fd45dd955a9dd54572e9~cDafI7a_t1935819358euoutp026
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;
	s=mail20170921; t=1521105788;
	bh=ZdgRbJpyPwLw3k4a4LUvd8LLUwt4qsxIUqXRU+R7cc8=;
	h=Date:From:To:Subject:In-reply-to:References:From;
	b=VGBVbSr+5XkDgvTRTR8qJr30x8dk1SJd668bIYMOQnEqy5ZULElT+eMIersYBlNXF
	 yLgSG3tXLqwxcIChtlwS/Wqu6wUpJBw2zcTmtnXfVsOBcoD/YKbA7cCb9tX8xbc3SN
	 Eg3TIO8Nq6Eqlwj2gjvHmTcUXUatIEHKs6Z49cck=
X-AuditID: cbfec7f4-713ff700000043e4-56-5aaa3b7b7af2
Date: Thu, 15 Mar 2018 09:23:05 +0000
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: $(<nofile) doesn't set $? to non-zero
Message-id: <20180315092305.6fe4ad17@camnpupstephen>
In-reply-to: <20180315071204.GA10057@chaz.gmail.com>
Organization: SCSC
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset="US-ASCII"
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7djPc7rV1quiDCYfE7c42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGb2tz1gLPrBVdL/+ytrAOJO1i5GTQ0LARGLpp72MXYxcHEIC
	Kxgl/u88zgTh9DJJLNtymAmm6vXeJhYQW0hgGaPEkxu8EEXTmCSOPfrJCuGcYZS4s3YzO0TV
	QUaJ/Q+rQWwWAVWJF0+vgsXZBAwlpm6azQhiiwhoSew4eRJsg7CAkcTqrtVgG3iBtr142wgU
	5+DgBLKvfTQCMfkFhCQuNNtC3GMvcXQPRCevgKDEj8n3wDqZBXQktm17zA5hy0tsXvOWGeQ0
	CYEJbBKr2j5Bvewi0d3wlQ3CFpZ4dXwLO4QtI9HZcZAJoqGZUWLt/ftQRT2MErMWh0LY1hJ9
	ty8yQmzgk5i0bTozyHESArwSHW1CECUeEj93H2eGsB0lOvsOMEPCZyOTRPP8btYJjPKzkBw+
	C8nhs5AcvoCReRWjeGppcW56arFRXmq5XnFibnFpXrpecn7uJkZg1J/+d/zLDsZdf5IOMQpw
	MCrx8N5QXhklxJpYVlyZe4hRgoNZSYT3fiFQiDclsbIqtSg/vqg0J7X4EKM0B4uSOG+cRl2U
	kEB6YklqdmpqQWoRTJaJg1OqgXF2/42Tc0KVRVqv/fMMd5zjxlC54+50gwvG6wMyZld+TOU/
	eODhwvm2KUySnecrCru0fR9OSrazLLS56xvWH7fu+onDK6fPiu5YtvBkhczylGO9LvIX/7uY
	SD6zqiletbdCcw9f0cOvl3yfHrNYv+P+Sh271Uu+3vHLaGxrXuT1Qsxz8SZXPhYlluKMREMt
	5qLiRAD57GUd9gIAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xy7pV1quiDGb3m1kcbH7I5MDoserg
	B6YAxigum5TUnMyy1CJ9uwSujN7WZ6wFH9gqul9/ZW1gnMnaxcjJISFgIvF6bxNLFyMXh5DA
	EkaJ3bcmMEE4M5gkVp58D5U5xyjR+OgRO4RzkFHi7PNvYP0sAqoSL55eZQex2QQMJaZums0I
	YosIaEnsOHmSCcQWFjCSWN21mgXE5gXa9+JtI1Ccg4MTyL720Qhi5mYmiedNk1hA4vwCQhIX
	mm0hzrOXOLoHYgyvgKDEj8n3wMYwA43fvK2JFcKWl9i85i0ziC0koC5x4+5u9gmMQrOQtMxC
	0jILScsCRuZVjCKppcW56bnFhnrFibnFpXnpesn5uZsYgUG77djPzTsYL20MPsQowMGoxMN7
	Q3lllBBrYllxZe4hRgkOZiUR3vuFQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK85w0qo4QE0hNL
	UrNTUwtSi2CyTBycUg2M/SabJ6gW6f8tZzD8qtyX8yfdsfV9ReLbFMs9N5uFj3dvaCvbMq0y
	SOr5nEluk4LPiXmvNb56Ls/w3kqTE0VGuUxPc6dYf5we9naSdt3yax8Zlj4q2Wt29Mf2q5Fq
	ewytHRn3P/EzCzdWbZCROvfnq8dLS3dr/5qFLm/2Tc6aXKXY86j9Z8NzJZbijERDLeai4kQA
	Gua/M1YCAAA=
X-CMS-MailID: 20180315092306eucas1p1456cf7c1622f5f4f55f1d3079d180542
X-Msg-Generator: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20180314103335epcas4p30222f0df02adda27cbddbe62075ff9ad
X-RootMTR: 20180314103335epcas4p30222f0df02adda27cbddbe62075ff9ad
References: <CGME20180314103335epcas4p30222f0df02adda27cbddbe62075ff9ad@epcas4p3.samsung.com>
	<20180314103254.GA10404@chaz.gmail.com>
	<20180314105442.28c5554a@camnpupstephen>
	<20180314144248.GC10404@chaz.gmail.com>
	<20180314145004.6e4b971b@camnpupstephen>
	<20180315071204.GA10057@chaz.gmail.com>

On Thu, 15 Mar 2018 07:12:04 +0000
Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> 2018-03-14 14:50:04 +0000, Peter Stephenson:
> > On Wed, 14 Mar 2018 14:42:48 +0000
> > Stephane Chazelas <stephane.chazelas@gmail.com> wrote:  
> > > Would it be worth doing some:
> > > 
> > >   	ret = readoutput(stream, qt);
> > > 	if (errno) {
> > > 	  zwarn("%e: %s", errno, s);
> > > 	  lastval = cmdoutval = 1;
> > > 	}
> > > 	return ret;
> > > 
> > > there (or something cleaner to avoid relying on errno)?  
> > 
> > The return value is the linked list as we're in the context of
> > substitution, not command execution, which isn't easy to change
> > without a complete rewrite.  
> [...]
> 
> Why not just pass the error as a return argument like in the
> patch below?

That should be more consistent, thanks.  I've committed it (minor
tweaks).

pws