From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4249 invoked by alias); 17 Mar 2018 23:17:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42475 Received: (qmail 10379 invoked by uid 1010); 17 Mar 2018 23:17:22 -0000 X-Qmail-Scanner-Diagnostics: from mail-pl0-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.160.41):SA:0(1.6/5.0):. Processed in 1.214793 secs); 17 Mar 2018 23:17:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/rLlrKCUhnDYod1lP6VrX748wXxSWZZJ/Egj3igd0dA=; b=P/COi3Y9lDR+ioDrXXnRLJSrzmzjsVQ+f+8/85yPXaLaWBNx5l8N3PpjWfrNqv/0+G R/g3gd1jE4C2B5sHbrSy1fmTDkcs05Alj8yteP8AIR3F86AYynUy8utaOGUas/FPIhwM P3p+QZjLzQZGeUeRTRfffe0t50M3lltQS7PStqffrkvgzmGow3Ek6A9j9NORcqaPPqK5 PGucNGce7vxA04lyEnhY0hB3vb4YY83M6yX8NC229yub4cTfU9qnlIvTbQpstCoiB6w/ u24nbNji/LyDFjdEm5TmhiDzRXR08bwAvRFkc6lhUBWBgPiv72XlVChcjJAFkgKTEWdd 7kIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/rLlrKCUhnDYod1lP6VrX748wXxSWZZJ/Egj3igd0dA=; b=JHqgrVM2UKbucjfDbS+k/3Pj6RfLiJM9KMm5JA9vs2FnExnel67lSnFMZrK39xFJFV WIOE/qw3CyILG7Lqq5g28RkEm+oqs4iI67OtMZfUddhZO/CIH2EWgEpsahAbaT0C6Kua rG/ewQFACjUT4Giqifz+L0WFm246vgkEINxVegOqhPKx8jgcRjJzrwOEnDhlIkKmhQtG DcnJIzlxcyDLZNSOVoJYVXuo4YUpOlORXMwTsyW/laAtyXBEVGox4hrkeNm5fhW37YH8 CHr/9GQ/1L+QEiPfmoQQKZQI512O0zGbF6mnXGnX1ArBwvLjcaFJahrYrLJ0iN7VfWGW GM0w== X-Gm-Message-State: AElRT7EHhvnGLLJMaFPAgcuc5Q38EbzmBbwIPnpbl1JZAV7LkR0Xyzuj IbXnWWuXXpaLi429Bhuc/jzhPw== X-Google-Smtp-Source: AG47ELtjJI4o4PUkHhEkRof5gU1lqy/2cIZ7ZN/ScikEKghQz8AuBpVB5lvP4R6rfZqS5Xwr8eacGQ== X-Received: by 2002:a17:902:28c3:: with SMTP id f61-v6mr7157671plb.346.1521328639016; Sat, 17 Mar 2018 16:17:19 -0700 (PDT) Date: Sat, 17 Mar 2018 13:17:15 -1000 From: Joey Pabalinas To: Oliver Kiddle Cc: "zsh-workers@zsh.org" , Taylor West Subject: Re: [RFC] Looking for opinions on accepting refactoring patches Message-ID: <20180317231715.dc5zcswwoe5vf2zx@gmail.com> References: <20180316203930.f6mikhp7iiltgmpb@gmail.com> <7323.1521286049@thecus> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v76hnnjrxknuttzk" Content-Disposition: inline In-Reply-To: <7323.1521286049@thecus> User-Agent: NeoMutt/20180223 --v76hnnjrxknuttzk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 17, 2018 at 12:27:29PM +0100, Oliver Kiddle wrote: > I'm sure any improvements would be welcomed. Notions on good > refactorings can be subjective; such as breaking a long function into > smaller ones where the original long function was neatly divided > into self-contained blocks anyway. So as always, it depends on the > particulars of the patch. Very true. > The best way to alleviate the risk of bugs is to add test cases at the > same time. If you're going through to make sense of the code, test cases > will occur to you naturally anyway. Running the existing tests with code > coverage enabled helps to see if code is getting any existing testing. > > And if you're willing to fix what you break then I can't see that anyone > can have any complaints: Alright, I agree that sounds like best way to manage regression risk. I most certainly am; it is very depressing when people break things but force others to fix them. > It may also help if, when choosing what code to refactor, you have > a longer term view to some bugs you'd like to see squished or even > features that might be added. Very good point as well. This is not something that will be undertaken lightly; I would have to spend a _LOT_ of time reading the code before any sort of refactoring is something I would feel comfortable attempting. Surgical changes very rarely work for things like this in my opinion; without the big picture it is very easy to make things worse. Appreciate the comments; keep it coming guys, thanks. --=20 Cheers, Joey Pabalinas --v76hnnjrxknuttzk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKlZXrihdNOcUPZTNruvLfWhyVBkFAlqtofsACgkQruvLfWhy VBmyzhAA6QEcGiE1Tn+hBTd+/RqFDvDbDBPga4VFh62UPaXEQjEayZC8JPzYpXVf FNmR7x/FI7HcVxhYZzlRAMQ6S2q6TgpxW944qiONEyODyrygujNOUF5X3A5IB0o3 7PDLnE1vt1953zQQxFB/rWt7cUi09dc2I6eyggJwwsrZ3MRXcMEyAd0k29BR1gvx e28nI/s9VA7Mf8FGdFymgb++MfADW5Vt6sY+agbEuACDi5Ma5iRoOOlKIXdUHScq x8Qv3uOrKBzwzTh3A4mDZjKJI1wXtYwoStBuHboVzGrXOOFPWgytUs2A8W9xVfaU cneWaC6Qp9anJpivhXPyWyUvM7Om6plu8LeHxkQHLjXGdtzKLnyl783o6If7kGLX CKnN8NGtpO2SItuTEh2dkUHacVkLjNEM6rE+8jRIRGox9hNcY3735UH8Octmut+F D0LQBxrEdy+zR2fAUbkobc7tisqdK5y4ODwzmjX50WV/fjuC7NfrfqTfXEjAUSSf RNWGiTZA8sy3LsXxfF+fJiGYom21BgHK1v8OBbZLHZgR8BMo2ioTIG9CvC/7Vjqe Xo8AcUryyewKBHC+I+c07poZ+GSOUqoPUJfmwH2kZp793UF7AahAiVWkP+tf6PXz Fe+JKEJcLytNx6tVbzdrdvFU/anB3Ntbhk0j8cSYF2jifSYGpfA= =cmsT -----END PGP SIGNATURE----- --v76hnnjrxknuttzk--