From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17204 invoked by alias); 22 Mar 2018 02:58:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42494 Received: (qmail 22678 invoked by uid 1010); 22 Mar 2018 02:58:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f179.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.179):SA:0(0.9/5.0):. Processed in 1.101246 secs); 22 Mar 2018 02:58:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: joeypabalinas@gmail.com X-Qmail-Scanner-Mime-Attachments: |signature.asc| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HYk9rbWxi1K15R0rTT675+fdIVTe1kAtg0PVXQXae9Y=; b=twz0/yrKI7u9Vfd8p2OaVO0YGdaMjnDU0doNHY3UDQ00pV4UlskW0sXSCIXP6+kPsw ENdc+6AZIgma1S0A694a3ruegnF7ZpGQsYTUXMj6cgwawtOgpzUp0Wxoi4II+Q0uLZjW kzAQTObI+qJaMfPcqbqHuqVPX3ezT3NyMMJ9fjMgRS1WVdAmr529BCVv2sdY1GPHoofS EbWHzJ9bgpDmYzq5ZWHun+i/C+x38JscK0RA7CxaTOsgv/Q/NebAEwnQUPHGrQ+H5WI/ p+4ZYZX7dWgEN1UMvBYnz163OhPVR31uBmnGENmMQQcUK7IxdhqulsingGybnW+wp+Jb JTbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HYk9rbWxi1K15R0rTT675+fdIVTe1kAtg0PVXQXae9Y=; b=gWg6GDm9qaYotyDNmTl4qBG1tgFKJ52a2/yrmoB8Hma6opzKaJUUh+TN+YLyWipHzj 2dRV4RLoEEAWZFHQIje0mCkFDDf3fm5Zy/cvCQvcOqoYljDRZgp0c4DV5XY1KtwXCIIy Gk2WNUf9OZAx/Ye8KJX9wikNeRankw0ki4Rjt7k2Ei3YI1W3EfyzKWV68zirbNv5zDzt eRoDqYqgNK3SNNc6hIkd3wMl1HBqjslmeItbZa2mzIU89FEw3QStrhVILEpXnTNCKp/4 6yUwq41uGnjHvdyTQc8IVGe2h04822C4FUPKb6yZGRPBJlvGB805nVrxibt1sLQO9+p5 KoXQ== X-Gm-Message-State: AElRT7GT1SG24wSnExUOLc5XC0YoNwOYQ/XL/lQ1MRHqpEAn7juoAGXR PQPjNwMUVuRUWopyq6DbDKg= X-Google-Smtp-Source: AG47ELt7JibaHlj0IZg7rMFJ/Aflqs3PF8XT1MGE2zUsqFXjqs3ITm05qYUkEhGIRFY4W46ChdlT4w== X-Received: by 10.101.90.10 with SMTP id y10mr2376149pgs.34.1521687491167; Wed, 21 Mar 2018 19:58:11 -0700 (PDT) Date: Wed, 21 Mar 2018 16:58:07 -1000 From: Joey Pabalinas To: Bart Schaefer Cc: Joey Pabalinas , "zsh-workers@zsh.org" Subject: Re: [PATCH] Allow '=' aliases to be used with -L Message-ID: <20180322025807.u3y7dph2vi6ls2ll@gmail.com> References: <20180322011905.45n377wsxp62k57e@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ejziewhzphjfj6yu" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 --ejziewhzphjfj6yu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 21, 2018 at 06:37:37PM -0700, Bart Schaefer wrote: > Unfortunately you can't put this in the base shell, because assignment > to the aliases array is only supported by a module. Ah you are right, I didn't realize that. How about if we check if the module is loaded first? If it happens to not be we can just use the old failure path. Revised patch below: 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/Src/hashtable.c b/Src/hashtable.c index b7baa314220509240d..53e7e99e1a9f1505b6 100644 --- a/Src/hashtable.c +++ b/Src/hashtable.c @@ -1303,11 +1303,23 @@ printaliasnode(HashNode hn, int printflags) } =20 if (printflags & PRINT_LIST) { - /* Fast fail on unrepresentable values. */ + /* + * '=3D' aliases need to be special cased with direct alias + * table assignment (`aliases[=3D]=3D...`). If the zsh/parameter + * module isn't loaded just print a warning and fail. + */ if (strchr(a->node.nam, '=3D')) { - zwarn("invalid alias '%s' encountered while printing aliases",=20 - a->node.nam); - /* ### TODO: Return an error status to the C caller */ + /* Fast fail on unrepresentable values. */ + if (!module_loaded("zsh/parameter")) { + zwarn("invalid alias '%s' encountered while printing aliases", + a->node.nam); + /* ### TODO: Return an error status to the C caller */ + return; + } + + printf("aliases[=3D]=3D"); + quotedzputs(a->text, stdout); + putchar('\n'); return; } =20 --=20 2.16.2 --ejziewhzphjfj6yu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKlZXrihdNOcUPZTNruvLfWhyVBkFAlqzG78ACgkQruvLfWhy VBkamQ/+N+CSoT8eQG2ZUBGSy2glvWUO6YrlF/74FfVjPA0eHPEj634JGnUnFoQn unnNKHp01jcXID2Kl2z7XYr5XLha391g/GkQNtvIlClCTn34AY4/+P5qRja0Gqvr G4lEOiHQTv0WbZpJqJZfNApdMWVfjXdtaycmfgHEd6Bg4LdtvF3I8awIFE/0bvD4 toC+LEcxBVhI+v6CRVWrmikqbfSJ7J+GrgzduLMOn7VTAo6+dC0GHMDEFCDfRheP 0QMkXT08MHhuaPDxoo82UDRdv/E4LIT//9btgD4TacZSJXZwR8zuuo0XDNjBZBfc 6kStaQ3is12wo120NOVnAWfTBGy3rE9ngpc/UOp8oRMEp1GLAZddkbXvbJBbJS47 OUA9u//s79opKSM62XDClaTFfE88wZZVOdhfN8N0YLOWb7gdiTArZ6JxSXk+tQt8 ldfGBFRXunlHX/ndzO+W1aSYVl8Wj9Hm6p7hEB0+t6JX7o+75+3ab6fizMvXl2Is YQDNots/GunLHmxjBWY/UES7QtHqMZdjH/gLw6YapnCDGl13dGC/H8gKGTK2dbde 51VWW8Kt66YZjLNgcqmYTW4u6E8UiixAXTkI6o6qhP0RKdrT/ebtdeawr+vZ/ZEn L85FAXa6kHxdEXe+7xF3+O/RHtiRlNQhK232S4xi0TpY5dt4vsE= =CBi9 -----END PGP SIGNATURE----- --ejziewhzphjfj6yu--