From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: remove dead code flagged by coverity
Date: Thu, 05 Apr 2018 14:29:00 +0100 [thread overview]
Message-ID: <20180405142900.66b2110f@camnpupstephen.cam.scsc.local> (raw)
In-Reply-To: <26567.1522930146@thecus>
On Thu, 05 Apr 2018 14:09:06 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Coverity correctly flags these two lines of code as being dead. This
> was added in 42332. Unless the intention was instead for
> zstrtoul_underscore() to also handle base#number syntax then this can
> go because it only looks for binary, octal, decimal and hex.
The only use of the function is to ensure we can get a maximum length
unsigned integer. The presence of base# would cause that case to
drop through to a mathevali(), which is what this code always
used before.
Logically, there is a gap as this doesn't handle 16#ffffffffffffffff,
I suppose.
pws
prev parent reply other threads:[~2018-04-05 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180405121007epcas4p383511f24b9e1aedbdee704db42382368@epcas4p3.samsung.com>
2018-04-05 12:09 ` Oliver Kiddle
2018-04-05 13:29 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405142900.66b2110f@camnpupstephen.cam.scsc.local \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).