PATCH: remove dead code flagged by coverity

PATCH: remove dead code flagged by coverity

[Oliver Kiddle]

Coverity correctly flags these two lines of code as being dead. This was
added in 42332. Unless the intention was instead for zstrtoul_underscore() to
also handle base#number syntax then this can go because it only looks
for binary, octal, decimal and hex.

Oliver

diff --git a/Src/utils.c b/Src/utils.c
index 3587c3622..c544b81bf 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2486,9 +2486,7 @@ zstrtoul_underscore(const char *s, zulong *retval)
 	base = 2, s++;
     else
 	base = isset(OCTALZEROES) ? 8 : 10;
-    if (base < 2 || base > 36) {
-	return 0;
-    } else if (base <= 10) {
+    if (base <= 10) {
 	for (; (*s >= '0' && *s < ('0' + base)) ||
 		 *s == '_'; s++) {
 	    if (*s == '_')

Re: PATCH: remove dead code flagged by coverity

[Peter Stephenson]

On Thu, 05 Apr 2018 14:09:06 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Coverity correctly flags these two lines of code as being dead. This
> was added in 42332. Unless the intention was instead for
> zstrtoul_underscore() to also handle base#number syntax then this can
> go because it only looks for binary, octal, decimal and hex.

The only use of the function is to ensure we can get a maximum length
unsigned integer. The presence of base# would cause that case to
drop through to a mathevali(), which is what this code always
used before.

Logically, there is a gap as this doesn't handle 16#ffffffffffffffff,
I suppose.

pws