From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24855 invoked by alias); 17 Apr 2018 12:53:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42670 Received: (qmail 25574 invoked by uid 1010); 17 Apr 2018 12:53:16 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi0-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.218.41):SA:0(-1.7/5.0):. Processed in 1.36969 secs); 17 Apr 2018 12:53:16 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: phy1729@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0nP9i8gkhWQ9eMnS2PpLdcx2sZ9TgnV/ie457DbhDxc=; b=dnij/ZrVc3sfU9Dg2TvjH48IqQDqWNlwR62NFTdftFDfsYxBfGfaL/1Xd8oaB77yEh j5joV+gBqr+cYzboYK9BXJXys54Itx1+LuE1iyuYcVJ/NESRhTAmmchDreBaJwjGnsMU MjhAsPYzVdPOk+VcVXDWcAsce8kCcyOAErIJkfPrsbG86+34A7K0o2LfeZmYCl4n/oKB nC7QIDS5TyKFNFi+Phtix4UUdz8OcrhLM9ob4lz6m00158ElSU0sr0wO+80IkORi79K6 q1TxvcyE/gQ4cqIx8etHNVGBu7SIdYLY0RFsvEsQAE2CBbgYbMZbuKgu7ObRc2qW5RpJ c38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0nP9i8gkhWQ9eMnS2PpLdcx2sZ9TgnV/ie457DbhDxc=; b=jHNsndSY8vHnf7dQA51VqnSlJcFzPodUHKb+sAi38fEjulJhCWsEtL9/X1iqZ3QGIe syAM3Bq/qMFqj4EAa3qcTH6LzK5LhjYl/puhHe4jddvDpsbo9wnG8bPxP6P39NP9+BZA Ko/6Z51z4QJldPN1n2Qy58A5APsj9R6234/F24cjwMsF5wicTCRSzcl/xsiN+DUHA9lV S1wzZH5RcaKE2f6CN1+8o4ZJzhUOY/eIL1siqbZpVAlWyvfo/9ULJAUgc+VDTPpdghJI w7KGa8Zp/3nsnVN7gPtD9c3xbioJ7mrP02pCa+bT5LQBYXbbxD3/Zu6H60eWP99+lPn7 u2VQ== X-Gm-Message-State: ALQs6tBa/rT2KK7QiMATBQGdjgFd8PILKjv44vnaJVSThSOIgVyniPYQ nPohpDtCoa1xuwV3orAzwa8iR82j X-Google-Smtp-Source: AIpwx4/RR75s7FziG1lezP2ayPzPkRycAbJTGSCFmiQsmTwRDy2gL8Xiq3DDdoYYfeFtcNJJDt+yqA== X-Received: by 2002:aca:5343:: with SMTP id h64-v6mr1029944oib.86.1523969592043; Tue, 17 Apr 2018 05:53:12 -0700 (PDT) Date: Tue, 17 Apr 2018 07:53:09 -0500 From: Matthew Martin To: zsh-workers@zsh.org Subject: Re: support more arguments to diff Message-ID: <20180417125307.GA34493@CptOrmolo.darkstar> Mail-Followup-To: zsh-workers@zsh.org References: <20180416145913.wv637mfnw5hfe2fi@Daniels-MacBook-Air.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) On Tue, Apr 17, 2018 at 04:22:38AM -0700, Eitan Adler wrote: > On 16 April 2018 at 07:59, Daniel Tameling wrote: > > On Sun, Apr 15, 2018 at 10:48:08PM -0700, Eitan Adler wrote: > >> This patch isn't perfect since {Net,DragonFly,Open,Free}BSD are not > >> identical but this patch at leasts makes the completion a lot closer > >> to reality. > >> > >> Currently FreeBSD doesn't even show -q for example. > >> > > > > Did the patch change the behavior of diff completion for you? On my > > FreeBSD, diff is some GNU variant, and I think that it's the default > > and that I didn't install it via pkg: > > FreeBSD is in the process of converting to a new diff implementation. > This resulted in me seeing a huge difference with this patch. > > I'd also like to port this particular diff implementation to the other > BSDs, hence adding all of them to the case statement. I think it would be best to add the other cases as each BSD adopts whichever diff. I generally try to update the completion to match -current, so when a new release is picked up the options are correct. > > I think the reason why there is only openbsd in the else branch is > > that all the other ship with some kind of GNU diff. (At least that is > > what the online man pages of dragonfly and netbsd indicate.) However, > > the versions seem to differ wildly across BSDs. > > Makes sense from a historical point of view. I think the real reason is I only bothered to update OpenBSD completion when I sent the patch. I usually shoot for [DFNO]BSD now. - Matthew Martin