From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1202 invoked by alias); 17 May 2018 08:44:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42793 Received: (qmail 13788 invoked by uid 1010); 17 May 2018 08:44:50 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-6.9/5.0):. Processed in 1.207908 secs); 17 May 2018 08:44:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180517084443euoutp02fa0f297c1a0d6c9d493d2e22dc81bfdb~vYh7zCnm_1033410334euoutp02y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1526546683; bh=QnxJuCc7/sqLXse4eWotHrS3ODRdXgPjrro+nJKRFPU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=M0XLiHdcxx0uV25oh6jepRQ26g7fjBs9H3qJ8/OFl0+ujvaG9+g6I3gaeGcuS/pfR 7USiDCY4Hzxm4JYfQqfPUVcfA2aNWo0PKWSEDxn0OWFLFoLsz2iA5pe+NMNFL7nlUC A9ZXt8ZuLvdPG4QOQo/RyAemT1c/8o3bEKw4o7XQ= X-AuditID: cbfec7f5-b5fff700000028a9-04-5afd40fa3bd4 Date: Thu, 17 May 2018 09:44:39 +0100 From: Peter Stephenson To: Zsh hackers list Subject: Re: build fails on systems without /dev/fd Message-ID: <20180517094439.5dcac8fc@camnpupstephen.cam.scsc.local> In-Reply-To: <20180516213133.GA7996@chaz.gmail.com> Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djP87q/HP5GGSw4q2NxsPkhkwOjx6qD H5gCGKO4bFJSczLLUov07RK4Mjoe7GAvuCVa8e//CaYGxm8iXYwcHBICJhLb7xp2MXJxCAms YJToP9vJCuH0MUk0rZ/MBuH0MkncPHqDpYuRE6yj//sLFojEckaJefvus8NVXZzeC1YlJHCG UWLFhTwI+wKjxJF3dSA2i4CqxNV5M5lAbDYBQ4mpm2YzgtgiAloSO06eBIsLCxhLTF+2nR3E 5hVwljjw/BFYDSdQ/OGkf8wgd/MLCElcaLaFOMhe4ugeiFZeAUGJkzOfgJ3ALKAtsWzha2aI mvdsEkufFkDYLhJX7/UxQtjCEq+Ob2GHsGUk/u+czwTyi4RAM6PE2vv32SASPYwSsxaHQtjW En23LzKC3MAsoCmxfpc+RNhWYvW3NkZIkPJJ3HgrCHECn8SkbdOZIcK8Eh1tQhDVahI7mrYy TmBUmYXk6FlIjp6FMH8BI/MqRvHU0uLc9NRi47zUcr3ixNzi0rx0veT83E2MwCRw+t/xrzsY 9/1JOsQowMGoxMO7w/pPlBBrYllxZe4hRgkOZiURXpMvQCHelMTKqtSi/Pii0pzU4kOM0hws SuK8cRp1UUIC6YklqdmpqQWpRTBZJg5OqQbG2d4nNFlEL/vYBuSp7moWeie+7pLv/dKnv56F 3b7+3n1V0Vux9j8t/7mPb5GUs1G8pbdxa9y8Kp1j+llze4zWfFurWjz/8dfXyYrO6SEN/g+D v/5e8NGrr0ixfmf79ZtHdA6vTndKN/QX/lKUw340x7Hav4G/dtbP9f66D7RFJ71z2G//Jvi5 EktxRqKhFnNRcSIAixzHF/4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e/4Xd2fDn+jDA5/M7A42PyQyYHRY9XB D0wBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 Gft+/2YruMtX0brjE2MD4zXuLkZODgkBE4n+7y9Yuhi5OIQEljJKvLu7iR0iISPx6cpHKFtY 4s+1LjaIom4midkvDzFBOGcYJT58nA6VucAo0fXzOSNIC4uAqsTVeTOZQGw2AUOJqZtmg8VF BLQkdpw8CRYXFjCWmL5sO9gKXgFniQPPH4HVcALFH076xwxiCwm0MUqsnm3dxcjBwS8gJHGh 2RbiInuJo3sgxvAKCEqcnPmEBcRmFtCUaN3+mx3C1pZYtvA18wRG4VlIymYhKZuFpGwBI/Mq RpHU0uLc9NxiI73ixNzi0rx0veT83E2MwKjYduznlh2MXe+CDzEKcDAq8fDusP4TJcSaWFZc mXuIUYKDWUmE1+QLUIg3JbGyKrUoP76oNCe1+BCjKTAsJjJLiSbnAyM2ryTe0NTQ3MLS0NzY 3NjMQkmc97xBZZSQQHpiSWp2ampBahFMHxMHp1QDo0CMTbinr6ugUpkIo43I5//pLTunc0x+ +qraXfEna/ejTC8O7uBpETlRtyuTjv6obmmQYuFjepb5++N5JbcKHo/OolMSi1fv3Vr056Gj ki1z1Xux5SE+v767WwoW5Gz5xpN85OaXR6t0PtpG5+/ddDnc+uTNppgpe8/tFrO78rjk4g7b rJwCJZbijERDLeai4kQAOkG//6ACAAA= X-CMS-MailID: 20180517084442eucas1p23a5767ca11b07482046248b42c77b853 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-MTR: 20180517084442eucas1p23a5767ca11b07482046248b42c77b853 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180516213205epcas3p21f26f4de3643a563f1ed41c7922bbee9 X-RootMTR: 20180516213205epcas3p21f26f4de3643a563f1ed41c7922bbee9 References: <20180516213133.GA7996@chaz.gmail.com> On Wed, 16 May 2018 22:31:33 +0100 Stephane Chazelas wrote: > building zsh on FreeBSD when /dev/fd is not mounted, I get: >=20 > exec.c: In function =E2=80=98closem=E2=80=99:=0D=0A>=20exec.c:4372:28:=20= error:=20=E2=80=98FDT_PROC_SUBST=E2=80=99=20undeclared=20(first=20use=20in= =20this=0D=0A>=20function)=20(all=20=7C=7C=20fdtable=5Bi=5D=20=21=3D=20FDT_= PROC_SUBST)=20&&=0D=0A>=20=0D=0A>=20I=20wouldn't=20know=20if=20it's=20only= =20a=20matter=20of=20=23ifdef'ing=20out=20the=20=22=7C=7C=0D=0A>=20fdtable= =5Bi=5D=20=21=3D=20FDT_PROC_SUBST=22=0D=0A=0D=0AHmm...=20we=20don't=20need= =20all=20that=20scar=20tissue=20associated=20with=20the=20fact=20this=0D=0A= value=20is=20only=20sometimes=20defined,=20and=20given=20it=20now=20means= =20we'd=20have=20to=0D=0Acast=20=22alL=22=20to=20void,=20I've=20decided=20t= hat's=20beyond=20the=20pain=20barrier.=0D=0A=0D=0AHere's=20a=20more=20compr= ehensive=20change=20(that=20chunk=20in=20exec.c=20now=20doesn't=0D=0Aneed= =20any=20work).=0D=0A=0D=0Apws=0D=0A=0D=0Adiff=20--git=20a/Src/jobs.c=20b/S= rc/jobs.c=0D=0Aindex=20330ee6b..38b3d89=20100644=0D=0A---=20a/Src/jobs.c=0D= =0A+++=20b/Src/jobs.c=0D=0A=40=40=20-1258,11=20+1258,7=20=40=40=20pipeclean= filelist(LinkList=20filelist,=20int=20proc_subst_only)=0D=0A=20=20=20=20=20= while=20(node)=20=7B=0D=0A=20=09Jobfile=20jf=20=3D=20(Jobfile)getdata(node)= ;=0D=0A=20=09if=20(jf->is_fd=20&&=0D=0A-=09=20=20=20=20(=21proc_subst_only= =0D=0A-=23ifdef=20FDT_PROC_SUBST=0D=0A-=09=20=20=20=20=20=7C=7C=20fdtable= =5Bjf->u.fd=5D=20=3D=3D=20FDT_PROC_SUBST=0D=0A-=23endif=0D=0A-=09=09))=20= =7B=0D=0A+=09=20=20=20=20(=21proc_subst_only=20=7C=7C=20fdtable=5Bjf->u.fd= =5D=20=3D=3D=20FDT_PROC_SUBST))=20=7B=0D=0A=20=09=20=20=20=20LinkNode=20nex= t=20=3D=20nextnode(node);=0D=0A=20=09=20=20=20=20zclose(jf->u.fd);=0D=0A=20= =09=20=20=20=20(void)remnode(filelist,=20node);=0D=0Adiff=20--git=20a/Src/z= sh.h=20b/Src/zsh.h=0D=0Aindex=208b48984..8535d48=20100644=0D=0A---=20a/Src/= zsh.h=0D=0A+++=20b/Src/zsh.h=0D=0A=40=40=20-454,15=20+454,14=20=40=40=20enu= m=20=7B=0D=0A=20=20*=20so=20the=20shell=20can=20still=20exec=20the=20last= =20process.=0D=0A=20=20*/=0D=0A=20=23define=20FDT_FLOCK_EXEC=09=096=0D=0A-= =23ifdef=20PATH_DEV_FD=0D=0A=20/*=0D=0A=20=20*=20Entry=20used=20by=20a=20pr= ocess=20substition.=0D=0A=20=20*=20This=20marker=20is=20not=20tested=20inte= rnally=20as=20we=20associated=20the=20file=0D=0A=20=20*=20descriptor=20with= =20a=20job=20for=20closing.=0D=0A+=20*=0D=0A+=20*=20This=20is=20not=20used= =20unless=20PATH_DEV_FD=20is=20defined.=0D=0A=20=20*/=0D=0A=20=23define=20F= DT_PROC_SUBST=09=097=0D=0A-=23endif=0D=0A-=0D=0A=20/*=0D=0A=20=20*=20Mask= =20to=20get=20the=20basic=20FDT=20type.=0D=0A=20=20*/=0D=0A