From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27990 invoked by alias); 13 Jun 2018 15:16:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42998 Received: (qmail 22935 invoked by uid 1010); 13 Jun 2018 15:16:14 -0000 X-Qmail-Scanner-Diagnostics: from mailout2.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.12):SA:0(-6.9/5.0):. Processed in 1.289749 secs); 13 Jun 2018 15:16:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180613151609euoutp02600d38a1d897096f7dfe53f82dfe76fe~3wSZg1aMb1849418494euoutp02T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1528902969; bh=/QVGPpygYBNMRSsL3XHFD4hZ86y6DVAObBkBkneCST0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=GDI3pgzs9Yp9jn3wXdXI+NysmYOfwIl5aaywpdI9hWy0PHA9csc8qppmxv5kAYKac MijKIj/CMBN8xrJUHzzKAK02K81LJ1UVqQWlraEaFkulClTwZU7zGPZQyHw/jH/WXP Rs1FEFmsynqzpcanujcqZIS17YQ9T4a8CFzosJms= X-AuditID: cbfec7f5-b45ff700000028a9-33-5b213536a620 Date: Wed, 13 Jun 2018 16:16:00 +0100 From: Peter Stephenson To: Zsh hackers list Subject: Re: [PATCH] Silence compilation warnings about setuid, setgid In-Reply-To: Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7djP87pmporRBmdmclocbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujOmrFjMV9LNULFs+k6WBcQFzFyMnh4SAicT/vmdsILaQwApG iVUdal2MXEB2H5PEpyUbGCGcXiaJa30rWWE6Di//xg6RWM4o8frbG2a4qpmvGpghZp1hlDhw NQYicYFRYs3K32AJFgFViYVtfWA2m4ChxNRNsxlBbBEBLYkdJ08ygdjCAm4Sm+dtBqvhFAiU OPz6EJDNwcEvICRxodkW4gp7iaN7IMp5BQQlTs58wgJiMwvIS2x/OwfsIAmBz2wSS57+hyoq k1i8sAfqBReJHa+2s0PYwhKvjm+BsmUkTk/uYYFobgc6etJrdginh1Fi09E7jBBV1hJ9ty8y glzELKApsX6XPkTYUeLfoW3sIGEJAT6JG28FIQ7ik5i0bTozRJhXoqNNCKJaTWJH01bGCYzK s5C8MAvJC7MQ5i9gZF7FKJ5aWpybnlpsnJdarlecmFtcmpeul5yfu4kRmApO/zv+dQfjvj9J hxgFOBiVeHg3yClGC7EmlhVX5h5ilOBgVhLh9XuhEC3Em5JYWZValB9fVJqTWnyIUZqDRUmc N06jLkpIID2xJDU7NbUgtQgmy8TBKdXAKOYokSGZd3bhEp0e8cr3Iv/fPF/7i+OOvOhcgfRM 0x0Klr85kuf+8jc/dXam7I6ED3skXy0pepkz7+zj5C212l2v/5xTbei233A+Le5CzwN7/qq6 fxbK/6x7D4a+eLl13Vbl55sMBT5P/eai2H/WMu+5YkHKBD7Fug1XCkp8l9XZaOirBiT+UmIp zkg01GIuKk4EAOv48RUBAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e/4PV1jU8Vog2WvxSwONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xvRVi5kK+lkqli2fydLAuIC5i5GTQ0LAROLw8m/sXYxcHEICSxkl9u9/AZWQkfh05SM7hC0s 8edaFxtEUTeTxO/mDkYI5wyjxOT7Z1ghnAuMEp/fHQRrZxFQlVjY1gdmswkYSkzdNJsRxBYR 0JLYcfIkE4gtLOAmsXneZrAaXgFniRcPJ4Kt4xQIlDj8+hAzxND5zBKr1xxn6WLk4OAXEJK4 0GwLcZK9xNE9EHN4BQQlTs58wgJiMwvoSJxYdYwZwpaX2P52DvMERuFZSMpmISmbhaRsASPz KkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMC42Hbs5+YdjJc2Bh9iFOBgVOLhjZBRjBZiTSwr rsw9xCjBwawkwuv3QiFaiDclsbIqtSg/vqg0J7X4EKMpMDAmMkuJJucDYzavJN7Q1NDcwtLQ 3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVANj1QHe9d4Po9xnpM5gvdPEdfnNT/52 BoX3Dkyd18J3Xf0rKWORqdq98Mcv5TecGRMLGO2W7skMKf++8pOPZcnB2X1T/l/99oxlwf3t omumpNd+0f62KzfObrbTx+bArVf/7mgsWXd07qeqk4oesade6nhp77zCmMQxX6p3qqfRgsK3 t4/+/x7pqMRSnJFoqMVcVJwIALzJ6f6hAgAA Message-Id: <20180613151604eucas1p2359cab40768707b24d71579fe0853996~3wSVPJg051449714497eucas1p2r@eucas1p2.samsung.com> X-CMS-MailID: 20180613151604eucas1p2359cab40768707b24d71579fe0853996 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180613115039epcas5p3f7e70bdce12919686a5dec9895782138 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180613115039epcas5p3f7e70bdce12919686a5dec9895782138 References: <20180613131021eucas1p263704fa9832375e6a49cf7f2077606dc~3ukj6hhqT1702017020eucas1p2W@eucas1p2.samsung.com> On Wed, 13 Jun 2018 08:08:27 -0700 Bart Schaefer wrote: > IIRC there are some cases in which setgid/setuid fail silently, i.e., > without changing anything but without setting errno. The second calls > are to double-check that the first one was not rogue in that way. > > This may have been isolated to a 1990s-era OS that is no longer at > issue. Either way there's no particular reason to save and report > errno from the first call. Thanks, I'll change to a cast to void. pws