From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28935 invoked by alias); 16 Jun 2018 02:14:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43029 Received: (qmail 17040 invoked by uid 1010); 16 Jun 2018 02:14:11 -0000 X-Qmail-Scanner-Diagnostics: from mail-pl0-f48.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.160.48):SA:0(-1.9/5.0):. Processed in 3.815559 secs); 16 Jun 2018 02:14:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: lists@eitanadler.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=from:to:cc:subject:date:message-id; bh=WuuReal8LxgeYI71U9e4oLKLnP/sVfudfMV01otUktw=; b=RWb5maw6O+HyjfFSD7suhNh8EwD6H3Yan+rSeMw+MWCerZlDgTv6RZVakuIQLi81LX zVKBZiUi+Jut5En8sAHwmWIdoiVZ9k0XlZWoYhpsPNdwlc4yQfAy2wMPaCLfu8HCcgVx f1W2h9A8FpF7xyrPmbMn1tytO+vOXNDFWJsVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WuuReal8LxgeYI71U9e4oLKLnP/sVfudfMV01otUktw=; b=YRq9NoUKPPzKF6dTDDkygpNIn3jWczKQcnXfBvNpcFOVKCeWlF0vEjW6lIyWGSPr2S YQrmzhHvzMp2l/x+Qw+A+VPV6j68Jx+y73q/hzhtDp7U5wsASPQtCgaRVgTNS8wD8R4a G4cKHXzvyvEsysHxX8Z3NExVScELLoaeXZRLi+QUdPLiiQ2Cx5zZld3Wp018WPc2MdcG uAhVZhP+inWiN9Ft6lI6o3NOLjHhVgb2KPIK7Jtvg3MNiHU0FDYRmIXSrmOkIdKrmaEQ DQ8J4nHVwjcxcfoz1Art7+GUoaQCXXTcC6hx45o5FAD4UghKWl4Yvd7PZg7OOma4r38L KXXA== X-Gm-Message-State: APt69E3uPjiRraPn9nDLxN+znbMfDy9as3VJlSCSHbblp3MupeSlRTLf cfbCpm6VfyEV1kV/j29vbUlMf07g X-Google-Smtp-Source: ADUXVKKgUcbebByz0Bbc2k222nq92kCGwwLfz8JUERtvd7nkJYC2YvuzB4EN1uIm9jmSYTDM0VSyCg== X-Received: by 2002:a17:902:8a94:: with SMTP id p20-v6mr4670540plo.258.1529115245004; Fri, 15 Jun 2018 19:14:05 -0700 (PDT) From: Eitan Adler To: zsh-workers@zsh.org Cc: Eitan Adler Subject: [PATCH 1/2] autoconf: follow the advice to assume RETSIGTYPE is void Date: Sat, 16 Jun 2018 01:04:26 +0000 Message-Id: <20180616010427.2916-1-lists@eitanadler.com> X-Mailer: git-send-email 2.17.1 This has not been an issue on any platform for over a decade. Signed-off-by: Eitan Adler --- Src/Modules/zftp.c | 2 +- Src/signals.c | 2 +- Src/signals.h | 2 +- configure.ac | 12 ------------ 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/Src/Modules/zftp.c b/Src/Modules/zftp.c index 24f4b4200..4aaa1f072 100644 --- a/Src/Modules/zftp.c +++ b/Src/Modules/zftp.c @@ -362,7 +362,7 @@ static jmp_buf zfalrmbuf; /* The signal handler itself */ /**/ -static RETSIGTYPE +static void zfhandler(int sig) { if (sig == SIGALRM) { diff --git a/Src/signals.c b/Src/signals.c index 4958534e2..20c6fdf4a 100644 --- a/Src/signals.c +++ b/Src/signals.c @@ -588,7 +588,7 @@ wait_for_processes(void) /* the signal handler */ /**/ -mod_export RETSIGTYPE +mod_export void zhandler(int sig) { sigset_t newmask, oldmask; diff --git a/Src/signals.h b/Src/signals.h index 1904f4326..41ac88cce 100644 --- a/Src/signals.h +++ b/Src/signals.h @@ -27,7 +27,7 @@ * */ -#define SIGNAL_HANDTYPE RETSIGTYPE (*)_((int)) +#define SIGNAL_HANDTYPE void (*)_((int)) #ifndef HAVE_KILLPG # define killpg(pgrp,sig) kill(-(pgrp),sig) diff --git a/configure.ac b/configure.ac index b46e2f4c2..7644ebe52 100644 --- a/configure.ac +++ b/configure.ac @@ -955,18 +955,6 @@ dnl -------------- dnl CHECK TYPEDEFS dnl -------------- -AC_DIAGNOSE([obsolete],[your code may safely assume C89 semantics that RETSIGTYPE is void. -Remove this warning and the `AC_CACHE_CHECK' when you adjust the code.])dnl -AC_CACHE_CHECK([return type of signal handlers],[ac_cv_type_signal],[AC_COMPILE_IFELSE( -[AC_LANG_PROGRAM([#include -#include -], - [return *(signal (0, 0)) (0) == 1;])], - [ac_cv_type_signal=int], - [ac_cv_type_signal=void])]) -AC_DEFINE_UNQUOTED([RETSIGTYPE],[$ac_cv_type_signal],[Define as the return type of signal handlers - (`int' or `void').]) - AC_TYPE_PID_T AC_TYPE_OFF_T AC_CHECK_TYPE(ino_t, unsigned long) -- 2.17.1