From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21138 invoked by alias); 16 Jun 2018 02:14:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43028 Received: (qmail 14150 invoked by uid 1010); 16 Jun 2018 02:14:11 -0000 X-Qmail-Scanner-Diagnostics: from mail-pg0-f45.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.83.45):SA:0(-1.9/5.0):. Processed in 1.932937 secs); 16 Jun 2018 02:14:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: lists@eitanadler.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=from:to:cc:subject:date:message-id; bh=RtPcjRgh0xR8EHFqkAjXpuG0d9wgDzbJ70pLlWKKc7s=; b=Yfa+Hrgc+y/S6IFyzIteD/PtsVbQA24MAQ+K4YmVpM1F3vfwKTR9W/2gGOFEhRbWSG lAovoEJnHQSC5gfiCQJmzROioV9WPOjvydm7TfTKeodHaTuhY9ZFmYOa6Z2vgtTFIKSp mqjxY4ZYwJ8fGFG/+B/e/YAkwf+Z4Rv1/ut5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RtPcjRgh0xR8EHFqkAjXpuG0d9wgDzbJ70pLlWKKc7s=; b=F32XnsILIcAU5YntT+NXiYLu32Yxkg6y+MWGgQll+TLcxyK7StA02A5F2UHplyypFj NuDBxBCOtwlVkBYfolZ4G69rl0oqoD0oDt5cHUVOkffkzI3P9G1Kw/NtaSzsIBsSs6ii u5TctE17r7zvuc+p2i8q+uhQpHa3KGDUBfFJybc//ZfFWk24eccsID1Y97C/txyvx5tx sBvCpjHH4dunnGjVsw6EkLwqfeGqmaJbYVw6mCJR8n22MCzx9ZaOCxsqQvSQOEkF7Q0W x3+i2dvKC98NXcdW0NA3cdMRaJfwRd4bZu+zvhx93CULgkW2N7pLHiup4R/j2Ru3HbXH 11dg== X-Gm-Message-State: APt69E2L7hPP/9Yr+xY6Ejfeq8UoeGh9iLP0zBhlDljUh4oY1FUNFQN5 7FiWCpOfXE5GX4fGCFaz8aThqUd0 X-Google-Smtp-Source: ADUXVKL7wT1Z92pBGLC2ljDI7wYj+b9oa7lU19TappDbYSNVzRdCOOO/4Hl61YGwP6KrFMx1vtUmAA== X-Received: by 2002:a62:b2c4:: with SMTP id z65-v6mr4514025pfl.21.1529115246781; Fri, 15 Jun 2018 19:14:06 -0700 (PDT) From: Eitan Adler To: zsh-workers@zsh.org Cc: Eitan Adler Subject: [PATCH 2/2] Fix two C nits Date: Sat, 16 Jun 2018 01:04:27 +0000 Message-Id: <20180616010427.2916-2-lists@eitanadler.com> X-Mailer: git-send-email 2.17.1 - avoid returning from a function that will never return - use "ifdef" instead of "if" for checking if preprocessor exists Signed-off-by: Eitan Adler --- Src/exec.c | 1 - Src/zsh_system.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Src/exec.c b/Src/exec.c index d44527841..b36bcef64 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -4954,7 +4954,6 @@ getpipe(char *cmd, int nullexec) execode(prog, 0, 1, out ? "outsubst" : "insubst"); cmdpop(); _exit(lastval); - return 0; } /* open pipes with fds >= 10 */ diff --git a/Src/zsh_system.h b/Src/zsh_system.h index 5339b496f..d9b8617c5 100644 --- a/Src/zsh_system.h +++ b/Src/zsh_system.h @@ -735,7 +735,7 @@ extern char **environ; /* These variables are sometimes defined in, * * and needed by, the termcap library. */ -#if MUST_DEFINE_OSPEED +#ifdef MUST_DEFINE_OSPEED extern char PC, *BC, *UP; extern short ospeed; #endif -- 2.17.1