From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21305 invoked by alias); 19 Jun 2018 14:13:31 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43066 Received: (qmail 7453 invoked by uid 1010); 19 Jun 2018 14:13:31 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-6.9/5.0):. Processed in 1.851346 secs); 19 Jun 2018 14:13:31 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180619141323euoutp01976be9da56d48e126f098e0304756ce3~5lTUYygVz1566715667euoutp01T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1529417603; bh=NyUzFiu9T+onk2yL6/gAnlckhuNH4vrrBV7ciUqUuz0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=srUrZz5EgC0J9ke2EbqDIS7O7mjl6Q2wsbATe5jbxej1VCBbsUXU2g14m/bGhklH9 thEl6VHHwu3OiXMCJA2+lLzFxrBRUw/SOAUZ8vRnLsWianZlWTiTeKII0vL6IZ97xS DS+nkbJCzp34MMo8ONGlBAU+gK+/ZeW291rdnc1U= X-AuditID: cbfec7f5-b45ff700000028a9-d8-5b290f82cce9 Date: Tue, 19 Jun 2018 15:13:19 +0100 From: Peter Stephenson To: Subject: Re: [PATCH 2/2] Fix two C nits In-Reply-To: <20180619134629.GA15318@zira.vinc17.org> Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7djP87pN/JrRBvvXc1ocbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujPk329gLHnNUXO/fzdTA+Iiti5GTQ0LARGJO6xEgm4tDSGAF o8S0170sEE4fk8TeI4uYIJxeJol1H36ywrRsvjabESKxnFHi0crZbHBVO/+egXLOMEose7OH HaRFSOACo8TqC7UgNouAqsTtHceYQGw2AUOJqZtARnFyiAhISlxrPg1mCwuoSzSu2MYMYnMK mEqcm3MYaA4HB7+AkMSFZluIK+wlju45CTaGV0BQ4uTMJywgNrOAvMT2t3OYQW6QEPjMJrHz wQ42iKIyiQePt7JDNLtITFm7lwXCFpZ4dXwLVFxG4v/O+UwQze2MEmsmvWaHcHoYJTYdvcMI UWUt0Xf7IiPIRcwCmhLrd+lDhB0lNl/8wwISlhDgk7jxVhDiID6JSdumM0OEeSU62oQgqtUk djRtZZzAqDwLyQuzkLwwC2H+AkbmVYziqaXFuempxcZ5qeV6xYm5xaV56XrJ+bmbGIHJ4PS/ 4193MO77k3SIUYCDUYmHl4FZM1qINbGsuDL3EKMEB7OSCC/DKY1oId6UxMqq1KL8+KLSnNTi Q4zSHCxK4rxxGnVRQgLpiSWp2ampBalFMFkmDk6pBsa4PbwsLIZ8Em4cvh/zpNdkLXq0Q3rZ V4F13EbKisf0LcxXfd5vpbT87hH+Ncria/Q1Sn81x+W6bGeoyzOZ2eeV4CzzXG2WW51s/7G/ USV32BrSe/Qj5Tsse7RttjRvelmeveVQr91WhTuRJ/ZdvvFZr+TK8+tz5fecOT/96DbXCL/n h5QW9yuxFGckGmoxFxUnAgDVv6SbAgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4Xd0Gfs1ogz/HzS0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xvybbewFjzkqrvfvZmpgfMTWxcjJISFgIrH52mzGLkYuDiGBpYwSDdN+M0EkZCQ+XfnIDmEL S/y51gXWICTQzSTx+JwphH2GUWLpFVWI5guMErPuTmcGSbAIqErc3nEMbBCbgKHE1E0gGzg5 RAQkJa41nwazhQXUJRpXbAOr5xVwlnhz5CNYnFPAVOLcnMPsEAuWMEm0PsjuYuTg4BcQkrjQ bAtxj73E0T0nmSBaBSVOznzCAmIzC+hInFh1jBnClpfY/nYO8wRG4VlIymYhKZuFpGwBI/Mq RpHU0uLc9NxiQ73ixNzi0rx0veT83E2MwIjYduzn5h2MlzYGH2IU4GBU4uFlYNaMFmJNLCuu zD3EKMHBrCTCy3BKI1qINyWxsiq1KD++qDQntfgQoykwLCYyS4km5wOjNa8k3tDU0NzC0tDc 2NzYzEJJnPe8QWWUkEB6YklqdmpqQWoRTB8TB6dUA6P/wymN5+uCbUWkFynzFLjtz/jLtstj rbPqpIciXIYxNVdzxSIPRUx1ybWbe1V//hK761qs+57+alZ2vyQ3W/7RmYQ96udL318u2L9k XW/E7z1XNt9qt02v/fSxipHfynLDffG7zzQ/Sm84Xjq/Tb5UoLH968OHl6aKrZ0tPjnu0aQZ CxrVufYqsRRnJBpqMRcVJwIA0EsXGZ4CAAA= Message-Id: <20180619141321eucas1p194af5292bb4f5030e0536c500ef9c6c5~5lTSLcvNm0521405214eucas1p1I@eucas1p1.samsung.com> X-CMS-MailID: 20180619141321eucas1p194af5292bb4f5030e0536c500ef9c6c5 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180616021439epcas4p327f4346b40d9e10d94ce055058fe0d71 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180616021439epcas4p327f4346b40d9e10d94ce055058fe0d71 References: <20180616010427.2916-2-lists@eitanadler.com> <20180618092243eucas1p133cc109ed17712cd4253a72da472fa54~5NsPXgtMr0676306763eucas1p1g@eucas1p1.samsung.com> <20180619134629.GA15318@zira.vinc17.org> On Tue, 19 Jun 2018 15:46:29 +0200 Vincent Lefevre wrote: > On 2018-06-18 10:22:41 +0100, Peter Stephenson wrote: > > On Sat, 16 Jun 2018 01:04:27 +0000 > > Eitan Adler wrote: > > > - avoid returning from a function that will never return > > > > > > diff --git a/Src/exec.c b/Src/exec.c > > > index d44527841..b36bcef64 100644 > > > --- a/Src/exec.c > > > +++ b/Src/exec.c > > > @@ -4954,7 +4954,6 @@ getpipe(char *cmd, int nullexec) > > > execode(prog, 0, 1, out ? "outsubst" : "insubst"); > > > cmdpop(); > > > _exit(lastval); > > > - return 0; > > > } > > The _exit function is non-standard. That means from the basic C point of view it's not safe simply to remove the return. We are not in the game of guessing what the compiler knows. As the code's uambiguously correct as it is, and the compiler is perfectly at liberty to optimise out the return if it knows the function won't return, it can stay as it is. Anything we *can* detect about the compiler / configuration is fair game for improvement, however... pws