From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27173 invoked by alias); 19 Jun 2018 15:59:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43069 Received: (qmail 748 invoked by uid 1010); 19 Jun 2018 15:59:44 -0000 X-Qmail-Scanner-Diagnostics: from mailout1.w1.samsung.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(210.118.77.11):SA:0(-6.9/5.0):. Processed in 1.928367 secs); 19 Jun 2018 15:59:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS,T_DKIMWL_WL_HIGH,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: p.stephenson@samsung.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180619155937euoutp018ac33f9ba9136e58b10670e64c609da5~5mwEldYkx0062100621euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1529423977; bh=iceGxrMToL+Bw6nmMy/sH1rAP0Al3KXlHpHFeKY5Z5k=; h=Date:From:To:Subject:In-Reply-To:References:From; b=rc4HirOWBDHk0zW0flMy71LIRImxOvjEfUb0Eczp3xPDSPW3hnDSVtDyaPOVvn9vo dAbbw8SFiXLFSxdcn7gj4tgRYQTKKMqYAmUv/jT04gmOSSohozKJaju+OpacJwhNby T3SL+FaZP4S2ppLv+hZ4UxZmNKUgc4XTiXPTlPRM= X-AuditID: cbfec7f2-1c1ff70000011644-75-5b29286843d1 Date: Tue, 19 Jun 2018 16:59:34 +0100 From: Peter Stephenson To: Subject: Re: [PATCH 2/2] Fix two C nits In-Reply-To: <20180619143834.GA17383@zira.vinc17.org> Organization: SCSC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7djP87oZGprRBl87xCwONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxtt7N1kLtnJUfHp2jbWB8TZbFyMnh4SAicSZ7tWMXYxcHEIC KxglLt9cxQzh9DFJfF3Tywbh9DJJLH++mwmmZdb3P+wQieWMEm/bGhnhqpbN6mSBcM4wShzf 9ANq2AVGiZ9NK8FWsgioSkxqO8cOYrMJGEpM3TSbEcQWEZCUuNZ8GswWFlCXaFyxjRnE5hQw lZjbcQsozsHBLyAkcaHZFuIMe4mje06CncQrIChxcuYTFhCbWUBeYvvbOWB7JQQ+s0k8O9vG AlFUJvHv2El2iGYXiUtTb7FA2MISr45vgYrLSJye3MMC0dzOKLFm0mt2CKeHUWLT0TuMEFXW En23L4JdxCygKbF+lz5E2FFi88U/LCBhCQE+iRtvBSEO4pOYtG06M0SYV6KjTQiiWk1iR9NW xgmMyrOQvDALyQuzEOYvYGRexSieWlqcm55abJiXWq5XnJhbXJqXrpecn7uJEZgOTv87/mkH 49dLSYcYBTgYlXh4GZg1o4VYE8uKK3MPMUpwMCuJ8DKc0ogW4k1JrKxKLcqPLyrNSS0+xCjN waIkzhunURclJJCeWJKanZpakFoEk2Xi4JRqYOyaw9rxeveH25aME++9DojXeKBtWm8RflFt zx/njH2bbmwqqKu/pfHteNvex9nG60QFeuQn2a4Ikdu2MS1dXe7de3XrpbsTOaY3V16c9Oe0 4Od9vLHzFncGN32VTdkVfmPbzouh3lKzF53Xq1l6ZLuYzq7Gf8JlNa9iNuw+Ydx9RuOJ6337 C1lKLMUZiYZazEXFiQDpBc86AwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e/4Xd10Dc1og5kHpC0ONj9kcmD0WHXw A1MAY5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJe xtt7N1kLtnJUfHp2jbWB8TZbFyMnh4SAicSs73/Yuxi5OIQEljJKLJr2mRUiISPx6cpHdghb WOLPtS6wBiGBbiaJztsGEA1nGCUmzV3ICuFcYJSYdWguWDeLgKrEpLZzYN1sAoYSUzfNZgSx RQQkJa41nwazhQXUJRpXbGMGsXkFnCWerzgOZnMKmErM7bjFCDF0D7PE2h3vgAZxcPALCElc aLaFuMhe4uiek0wQvYISJ2c+YQGxmQV0JE6sOsYMYctLbH87h3kCo/AsJGWzkJTNQlK2gJF5 FaNIamlxbnpusZFecWJucWleul5yfu4mRmBUbDv2c8sOxq53wYcYBTgYlXh4GZg1o4VYE8uK K3MPMUpwMCuJ8DKc0ogW4k1JrKxKLcqPLyrNSS0+xGgKDIyJzFKiyfnAiM0riTc0NTS3sDQ0 NzY3NrNQEuc9b1AZJSSQnliSmp2aWpBaBNPHxMEp1cDoG/i8ZYNqYgarj/6e29yHzS4ZfDq9 sN/o2P0bJ1Zc/LrlgPW3PZ9ilk3/uM+PJWOyokz+nwb2zl2dZY1Wl2aWPBY+W7zI1/raBl8m J5VCg+nFlbW9mkJXONdKWU3q/aM0MZzt39WpUTyunZr27H8+HNHVurt/c8bTIo//h9nnLfuz diVHrJykEktxRqKhFnNRcSIAbBoIDaACAAA= Message-Id: <20180619155935eucas1p1eb3cceccb18423c4b00028059c8482e7~5mwC17Zmg2368823688eucas1p1K@eucas1p1.samsung.com> X-CMS-MailID: 20180619155935eucas1p1eb3cceccb18423c4b00028059c8482e7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180616021439epcas4p327f4346b40d9e10d94ce055058fe0d71 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180616021439epcas4p327f4346b40d9e10d94ce055058fe0d71 References: <20180616010427.2916-2-lists@eitanadler.com> <20180618092243eucas1p133cc109ed17712cd4253a72da472fa54~5NsPXgtMr0676306763eucas1p1g@eucas1p1.samsung.com> <20180619134629.GA15318@zira.vinc17.org> <20180619141321eucas1p194af5292bb4f5030e0536c500ef9c6c5~5lTSLcvNm0521405214eucas1p1I@eucas1p1.samsung.com> <20180619143834.GA17383@zira.vinc17.org> On Tue, 19 Jun 2018 16:38:34 +0200 Vincent Lefevre wrote: > It's safe because whether the "return 0;" line is here or not, this > will not change the behavior since this line is not reachable (even > if the compiler doesn't know this). > > If the compiler doesn't know that _exit never returns, it will > typically add an instruction corresponding to the "return 0;", If I were a compiler and I saw static int getpipe(char *cmd, int nullexec) { /* ... blah ... */ some_random_function(); } I would immediately warn about missing return values --- indeed, gcc does this with functions it hasn't been told about as I tested: gcc_return.c:14:1: warning: no return statement in function returning non-void [-Wreturn-type] so we've taken a step back in terms of clean code (even if gcc itself isn't the problem on a typical GNU-based system where it does know about _exit). Anyway, I've completely lost interest in this non-issue with what's currently entirely valid code and don't propose to discuss it further. pws