From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: A repeating core, just sharing backtrace
Date: Tue, 10 Jul 2018 14:38:32 +0100 [thread overview]
Message-ID: <20180710133834eucas1p20aa4ca380dfa7544a37e00accad3ecea~ABX6FaDE52812528125eucas1p2T@eucas1p2.samsung.com> (raw)
In-Reply-To: <20180710143319.340e1bdf@camnpupstephen.cam.scsc.local>
On Tue, 10 Jul 2018 14:33:19 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> diff --git a/Src/exec.c b/Src/exec.c
> index 5864020..47a4567 100644
> --- a/Src/exec.c
> +++ b/Src/exec.c
> @@ -4418,7 +4418,9 @@ gethere(char **strp, int typ)
> while ((c = hgetc()) == '\t' && strip)
> ;
> for (;;) {
> - if (bptr == buf + bsiz) {
> + if (bptr >= buf + bsiz - 1) {
... make that "-2", because we need to allow for two *more* updates.
The previous logic just allowed for where we'd already got to, because
it just needed to check one position. That doesn't work any more.
pws
next prev parent reply other threads:[~2018-07-10 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 10:09 Sebastian Gniazdowski
2018-07-05 13:40 ` Sebastian Gniazdowski
2018-07-10 13:33 ` Peter Stephenson
[not found] ` <20180710143319.340e1bdf@camnpupstephen.cam.scsc.local>
2018-07-10 13:38 ` Peter Stephenson [this message]
2018-07-10 15:12 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180710133834eucas1p20aa4ca380dfa7544a37e00accad3ecea~ABX6FaDE52812528125eucas1p2T@eucas1p2.samsung.com' \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).