From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5496 invoked by alias); 18 Jul 2018 11:54:42 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43185 Received: (qmail 2179 invoked by uid 1010); 18 Jul 2018 11:54:42 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.175):SA:0(-1.7/5.0):. Processed in 2.597083 secs); 18 Jul 2018 11:54:42 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: phy1729@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:mime-version :content-disposition:user-agent; bh=fzSwYcKOflPpVUdhsW6GZUkhsiQc3QfgVoAK+J0InyM=; b=tiUKN0hZfnjicB8sXYsAOuua/4b8NZ2hRkJlVhQEiDMMVe9cJ99G483yQ+EfxIK3Im OS5IQQcJpg6CXMrjxr+QGZ7hCCIsvJYhwyZccUTROT7V9SjLWSsKV7TtEJNZOIqPIBtq IOld4giALUReA3XFCrWTgkB76/Hcg0sa+is9FSC57bY+4Q3UiWvIFcGUzeltrfyTi9cq 4OTY3QYq9YdTKglJHbeVNdlwsaCfUq/kROrjc5BHAW3GLX7HDGXJkHSLb+xgbkPlYutl FGZSDj05S7M6484z0CI9USBWquhBbeR8RFHw1eKfMEeO6CRehRX+r5uO/B64Vzx+UE5V +0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :mime-version:content-disposition:user-agent; bh=fzSwYcKOflPpVUdhsW6GZUkhsiQc3QfgVoAK+J0InyM=; b=F0wYruX6oPVu3U3wBINoKur5hHnwCe5yvJXtw3wm2ceCUer4u50gKTOiY9uevrLgeC we9HMoQfsgMxYReHcwyXR5LuW59NQO89OcaPaxusvrNu4uTMbHYDFZl9gr+OP7XV7Ayt tOdQlTNqBGx+bh9mhi8lq7SC/g4jkd6dv6r5wZa7QIaozE3+DKiIRcMKXc5gZoAYl6nk dqkaP8ew1ZE1x8qjxZWcBp8YED7XiwuyFg1KZ+Qh+XamxK0VcUryO/m0cYV0qTZhZXE+ 6i7DrFwCSx6fPYkBZX9WDzqRx+w7GcY7CEQ0aij3Mmzs9l7JFHYDtOB3aHJJQGYrBXOe el8g== X-Gm-Message-State: AOUpUlEZJDECnPb5EJ6XZseyyNVrzRMZ2zpglL1ufJ3MWRNpc1PLxiRG 8Tsdpdob5CWGKJ1xc4cqjeUXOT7E X-Google-Smtp-Source: AAOMgpdU1J57WEXaDiJrHepsdoc6OY5sv4a+8hr25ZlUyf/d7HyCkVBh8arrQR89NTdK8IzbA3Dt+w== X-Received: by 2002:a0c:92e4:: with SMTP id c33-v6mr5943614qvc.178.1531914875659; Wed, 18 Jul 2018 04:54:35 -0700 (PDT) Date: Wed, 18 Jul 2018 06:54:34 -0500 From: Matthew Martin To: zsh-workers@zsh.org Subject: [patch] Associative array suffix in command position Message-ID: <20180718115433.GA75545@CptOrmolo.darkstar> Mail-Followup-To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.0 (2018-05-17) When completing an associative array in the command position = is used as the suffix. I think it's more likely (at least in my own usage) that the user only wants to change a single key not the entire array. Thus use [ as the suffix not =. There could be a zstyle knob to pick = or [, but I don't think it'd be used. So unless someone speaks up, I'm inclined to omit the knob. - Matthew Martin diff --git a/Completion/Zsh/Type/_command_names b/Completion/Zsh/Type/_command_names index 940f341cb..96ea57687 100644 --- a/Completion/Zsh/Type/_command_names +++ b/Completion/Zsh/Type/_command_names @@ -31,7 +31,8 @@ else 'suffix-aliases:suffix alias:_suffix_alias_files' 'reserved-words:reserved word:compadd -Qk reswords' 'jobs:: _jobs -t' - 'parameters:: _parameters -g "^*readonly*" -qS= -r "\n\t\- =["' + 'parameters:: _parameters -g "^*(readonly|association)*" -qS= -r "\n\t\- =["' + 'parameters:: _parameters -g "*association*~*readonly*" -qS\[ -r "\n\t\- =["' ) fi